Support ksqlDB window grace periods and EMIT FINAL - #2571
Open
minleejae wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ksqlDB queries fail on unparenthesized JOIN windows, grace periods and
EMIT FINAL. Support these forms while retaining the existing parenthesized single-duration and asymmetric JOIN windows:Reuse one duration production across JOIN, HOPPING/SESSION/TUMBLING and grace periods.
KSQLWindow.Durationexposes the grace value and time unit, distinguishing an omitted grace period from zero. JOIN windows preserve their bracket style.PlainSelect.EmitModeexposes NONE/CHANGES/FINAL while the existing boolean API keeps its default behavior; model and deparser share EMIT rendering. A contextual alias check recognizesWITHINdurations without reserving ordinary aliases namedwithin.Validation:
checkand Mavenverify.Fixes #1752.