You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
updateComputedPosition closes over computedPosition and lists its
sub-properties (offset, rect.left, rect.width) as useCallback
dependencies. This means every call to setComputedPosition produces a
new callback identity, which invalidates the useLayoutEffect([updateComputedPosition]) and immediately re-fires the
callback.
Under subpixel-drifting conditions (zoomed-out viewport, scrollable
ancestor, or fractional DPI) the measured offset oscillates by <1px
between frames. Each oscillation triggers setComputedPosition →
identity change → effect re-run → repeat, until React throws:
Track computedPosition in a ref so the comparison inside updateComputedPosition always reads the latest value without the
callback depending on it. This gives updateComputedPosition a stable
identity across renders and breaks the loop.
Reproduction
Render a portaled <Select menuPosition="fixed" /> inside a scrollable container
Set browser zoom to 90% or 110% (triggers subpixel rect drift)
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Just to pile on, we are also seeing this issue and this fix seems to address the underlying issue in our use case.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
updateComputedPositioncloses overcomputedPositionand lists itssub-properties (
offset,rect.left,rect.width) asuseCallbackdependencies. This means every call to
setComputedPositionproduces anew callback identity, which invalidates the
useLayoutEffect([updateComputedPosition])and immediately re-fires thecallback.
Under subpixel-drifting conditions (zoomed-out viewport, scrollable
ancestor, or fractional DPI) the measured
offsetoscillates by <1pxbetween frames. Each oscillation triggers
setComputedPosition→identity change → effect re-run → repeat, until React throws:
Fixes #6003.
Solution
Track
computedPositionin a ref so the comparison insideupdateComputedPositionalways reads the latest value without thecallback depending on it. This gives
updateComputedPositiona stableidentity across renders and breaks the loop.
Reproduction
<Select menuPosition="fixed" />inside a scrollable container