Reduce need to work arounds #337

Activity

1. senid231

   self-assigned this

   on Mar 26, 2019
2. senid231

   pinned this issue on Mar 26, 2019
3. code-bunny commented on Mar 26, 2019

   

   code-bunny

   on Mar 26, 2019

   Author

   More actions

   Another oddity discovered required a wee bit more work.

   class Foo < JsonApiClient::Resource
     property :fuzz
   end
   
   class Bar < JsonApiClient::Resource
     has_one :foo
     has_many :foos
   end
   
   bar = Bar.new
   bar.foo = Foo.new(fuzz: "Buzz") #<Foo:@attributes={"type"=>"foos", "fuzz"=>"Buzz"}> 
   bar.foo #<Foo:@attributes={"type"=>"foos", "id"=>nil}> 
   bar.foo.fuzz #nil
   bar.foos = [Foo.new(fuzz: "Buzz"), Foo.new(fuzz: "Buzz")] #[#<Foo:@attributes={"type"=>"foos", "fuzz"=>"Buzz"}>, #<Foo:@attributes={"type"=>"foos", "fuzz"=>"Buzz"}>]
   bar.foos.first.fuzz #nil
4. senid231 commented on Mar 26, 2019

   

   senid231

   on Mar 26, 2019

   Member

   More actions

   @code-bunny this is not an oddity.
   According to spec client can send only relationship id and type
   currently when you assign relationship to resource it only stores it's id and type
   when you accessing relationship via getter method it recreates object according to id and type and cache it (for performance).

   Can you give me usecase when you need to access relationship attributes of object which you currently create/update ?
5. code-bunny commented on Mar 26, 2019

   

   code-bunny

   on Mar 26, 2019

   Last edited by code-bunny

   Author

   More actions

   @senid231 so an example where we would want to access the relationship before committing it is for instance when using a wizard like an order checkout.

   class Item < JsonApiClient::Resource
     property :title
   end
   
   class Order < JsonApiClient::Resource
     include SomeStepWizard
   
     has_many :items
   end
   
   order = Order.new
   order.step # 1
   order.items = [Item.find(1).first]
   
   order.next_step
   
   # in some view
   order.items.each { |item| puts "Thank you for wanting to buy #{item.title}" }
   
   order.save

   Basically when we assign a resource it should behave in the same was is if we had run an include on the endpoint. This would keep the behaviour consistent as demonstrated in my example.

   bar = Bar.includes(:foo).find(1).first
   bar.foo.hello # "world"
   
   bar = Bar.new
   bar.foo = Foo.find(1).first
   bar.foo.hello # "world"