Repository navigation
Support keyword batches on prepared statements - #59
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 82.25% 82.40% +0.14%
==========================================
Files 1 1
Lines 124 125 +1
==========================================
+ Hits 102 103 +1
Misses 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
executemany(conn, sql; id=[1, 2])works, but the same keyword batch against an already prepared statement raisesMethodError. The documented no-parameterexecutemany(stmt)form also has no method.Add the prepared-statement keyword wrapper, delegating to the existing batch implementation like the connection form. Keyword batches retain positional field-order semantics. Tests cover batch values, invalid lengths, empty batches, no parameters, cursor cleanup, and keeping the caller's statement open.
Validation: the missing-method reproduction fails on master. Full test suites pass on Julia 1.9.4 and 1.12.6 with four threads.
Co-authored by Codex