With the v3.6.0 update in
#117
one function add_active_gotos! has changed the number of arguments it accepts - with the result that downstream that uses LoweredCodeUtils now may break: a common setup is to have both Revise.jl and JET.jl, both of them uses LoweredCodeUtils but with default/no [compat] section, it would update LoweredCodeUtils to 3.6.0, and break JET.jl
aviatesk/JET.jl#823
Is it better/more up to downstream to pin a version/change code, or is it better to add a default argument so the old 4-arg call without specifying controller still works?
|
function add_active_gotos!(isrequired, src::CodeInfo, cfg::CFG, postdomtree, controller::SelectiveEvalController) |
change to something like:
add_active_gotos!(isrequired, src::CodeInfo, cfg::CFG, postdomtree, controller::SelectiveEvalController=SelectiveEvalController())
With the v3.6.0 update in
#117
one function
add_active_gotos!has changed the number of arguments it accepts - with the result that downstream that usesLoweredCodeUtilsnow may break: a common setup is to have both Revise.jl and JET.jl, both of them uses LoweredCodeUtils but with default/no [compat] section, it would update LoweredCodeUtils to 3.6.0, and break JET.jlaviatesk/JET.jl#823
Is it better/more up to downstream to pin a version/change code, or is it better to add a default argument so the old 4-arg call without specifying controller still works?
LoweredCodeUtils.jl/src/codeedges.jl
Line 933 in 77d6e95
change to something like: