Repository navigation
Implement submission rules. Be stricter with status at time limit - #496
Merged
pehrsoderman merged 3 commits intoOct 8, 2026
Merged
Conversation
…us at time limit be an ERROR This PR starts implementing rules for submission outcomes (to eventually support submissions.yaml). Here, we implement the `permitted` and `score` rules, and use them in legacy to replace our hand-built rules for submission checks. Earlier, having the submission status be incorrect at the time limit, but ok at the safety margin was just a warning. I don't see how we can support this cleanly going forward, so now, an incorrect status at the time limit is an error.
pehrsoderman
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR starts implementing the infrastructure we need to support
submissions.yaml- in particular we add thepermittedandscorerules (globally scoped).We use these in legacy, and replace many of the submission checks with these new rules.
Functional changes:
Fixes #445