Repository navigation
Add Files to model. Ignore dotfiles in packages - #503
Merged
Merged
Conversation
pehrsoderman
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
Filesclass to the model of a problem package, keeping track of what files and directories we consider part of the package. This allows us to follow the updated rule in the standard asking us to ignore files and directories starting with a dot.In this PR, we also move program discovery from
runtomodel, cleaning up a dependency inversion. That code is moved + adjusted to useFilesinstead of iterating through directories (git diff --color-movedstill gets a bit messy due to using files there).Fileshave not yet been plugged into statements, asproblem2pdfandproblem2htmldon't use the model (yet), so that's for a future PR.Ignoring dotfiles properly means we no longer give errors for dotfiles, e.g., editing a file in vim. This fixes the actionable parts of #374.
Fixes #374