Skip to content

feat(demo): add duplicate button so duplicating is testable - #107

Merged
vitormattos merged 3 commits into
LibreSign:mainfrom
nva138:feat/demo-duplicate-button
Sep 19, 2026
Merged

vitormattos merged 3 commits into
LibreSign:mainfrom
nva138:feat/demo-duplicate-button

Conversation

@nva138

@nva138 nva138 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Part of #82. I didn't want to leave the duplicate interaction unfinished, so I added the button myself, hope thats okay. Now the duplicate test passes too.

Signed-off-by: Maximilian Mayer <office@maximilianmayer.at>
Signed-off-by: Maximilian Mayer <office@maximilianmayer.at>
@nva138
nva138 requested a review from a team as a code owner September 11, 2026 11:00
Comment thread e2e/signature-actions.spec.ts
@nva138 nva138 mentioned this pull request Sep 18, 2026
Signed-off-by: Maximilian Mayer <office@maximilianmayer.at>
@nva138

nva138 commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

Good catch. Now compares bounding boxes: same size, offset down and right. Not asserting the exact 12px from duplicateObject, on screen it is scaled by zoom (13.2px at default).

@vitormattos
vitormattos merged commit eb1c3c4 into LibreSign:main Sep 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants