Repository navigation
feat(roles/duplicity): back up the data of all LFOps applications by default - #407
Merged
Merged
Conversation
…default
Add /data, /srv, /var/lib/{grafana,icinga2,shiny-server,turn}, /var/mail,
/var/named, /var/solr/data, /var/spool/mail and /var/www/html (without the
repository mirrors) to duplicity__backup_sources__role_var. The setup_*
playbooks do not run duplicity, so a __dependent_var injection would have
no effect; the role defaults are the only place that works.
Document the rule in CONTRIBUTING.md so new roles extend the list.
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The default duplicity sources only covered
/backup,/etc,/home,/opt,/root,/var/lib/aideand/var/spool/cron, and no role or playbook injected further paths. Application data such as/var/lib/grafana(grafana.db),/var/lib/icinga2(the Icinga2 CA), the Nextcloud/Moodle data in/dataor the web roots in/var/www/htmlwas not backed up.This adds to
duplicity__backup_sources__role_var:/data(Nextcloud, Moodle)/srv,/var/lib/shiny-server(Shiny Server)/var/lib/grafana/var/lib/icinga2/var/lib/turn(coturn)/var/mailand/var/spool/mail(both, since one of them is a symlink depending on the distribution, and duplicity only stores the link of a symlinked source path)/var/named(BIND)/var/solr/data/var/www/html, excluding the repository mirrorsgithub-reposandreposync-reposdubaskips paths that do not exist, so hosts without these applications are not affected. Databases stay covered by their dumps in/backup, not by their live data directories.The
setup_*playbooks do not run the duplicity role, so injecting viaduplicity__backup_sources__dependent_varwould have no effect; the role defaults are the only place that works.CONTRIBUTING.mdnow says so, so new roles extend the list.Testing
duba.jsonwith the new defaults via Ansible; a host-levelstate: 'absent'for/dataremoves the entry.setup_basicMolecule scenario skips duplicity.