Skip to content

fix(linux): forward compose key from Menu input - #171

Merged
ReenigneArcher merged 1 commit into
masterfrom
fix/linux/compose-key
Sep 29, 2026
Merged

ReenigneArcher merged 1 commit into
masterfrom
fix/linux/compose-key

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Properly forwards compose key on Linux backend.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-29T23:20:01.755658Z 9b91412 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b914120a1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/platform/linux/uhid_backend.cpp
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.62%. Comparing base (88ff869) to head (9b91412).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage   70.55%   70.62%   +0.07%     
==========================================
  Files          47       47              
  Lines       10789    10791       +2     
  Branches     3791     3792       +1     
==========================================
+ Hits         7612     7621       +9     
- Misses       2507     2747     +240     
+ Partials      670      423     -247     
Flag Coverage Δ
FreeBSD 52.58% <0.00%> (-0.03%) ⬇️
Linux-Clang 55.45% <100.00%> (+0.03%) ⬆️
Linux-GCC 66.17% <100.00%> (+0.01%) ⬆️
PowerShell 75.60% <ø> (ø)
Windows-MSVC 88.77% <ø> (+0.07%) ⬆️
Windows-MinGW-UCRT64 63.74% <ø> (+0.16%) ⬆️
macOS 44.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/uhid_backend.cpp 81.38% <100.00%> (+0.07%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ff869...9b91412. Read the comment docs.

@ReenigneArcher
ReenigneArcher merged commit 2674189 into master Sep 29, 2026
34 checks passed
@ReenigneArcher
ReenigneArcher deleted the fix/linux/compose-key branch September 29, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linux compose key not working Keyboard compose key (Menu/VK_APPS) silently dropped since libvirtualhid migration (2026.906)

1 participant