Skip to content

Fix licensing page structure in docs ToC - #4664

Merged
jbogard merged 2 commits into
mainfrom
docs/licensing-toc
Oct 16, 2026
Merged

jbogard merged 2 commits into
mainfrom
docs/licensing-toc

Conversation

@jbogard

@jbogard jbogard commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

The License configuration page had no top-level heading, so Sphinx promoted each ### section into the Overview table of contents.

  • Add a # Licensing title
  • Promote the remaining headings one level so subsections nest under it

Also pins System.Security.Cryptography.Pkcs to 10.0.13 in the integration test project. New advisories (GHSA-2fmv-rv2c-59x7, GHSA-846f-f764-76mx) against the 9.0.4 version pulled in via Microsoft.Data.SqlClient were failing NuGet restore for every build.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 16, 2026 19:55
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T20:03:59.731160Z 4756177 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation-only changes establish the intended heading hierarchy without altering content.

0 open findings

What changed in this PR

Corrects the licensing page’s heading hierarchy so its sections nest properly in the Sphinx table of contents.

Changes:

  • Adds a top-level Licensing heading.
  • Promotes existing headings one level without changing their content.
File Description
docs/​source/​License-configuration.md Establishes the page title and consistent section nesting.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Patches GHSA-2fmv-rv2c-59x7 and GHSA-846f-f764-76mx, pulled in transitively
via Microsoft.Data.SqlClient; NuGet audit fails the build otherwise.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jbogard
jbogard merged commit 3019d86 into main Oct 16, 2026
6 checks passed
@jbogard
jbogard deleted the docs/licensing-toc branch October 16, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants