chore: turn off invocation logs and log sampling - #22
Merged
Merged
Conversation
logs.enabled = false alone did not stop Workers Logs from storing invocation logs. Turning off invocation_logs and sampling logs at 0% did (verified on thirdpartycache, LunarClient/Web#433). Traces unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns off invocation logs and sets the log sampling rate to 0 for
skycrypt-embed.logs.enabledstaysfalseand traces are unchanged.logs.enabled: falsealone (the previous PR) did not stop Workers Logs from storing invocation logs. This combination did: LunarClient/Web#433 applied it to thirdpartycache, and stored invocation logs went from ~6K/minute to zero in the first minute after deploy.🤖 Generated with Claude Code