Repository navigation

GH-605: Review two - #704

Open

utkarshg6 wants to merge 63 commits into

GH-605-review-1-basefrom

GH-605

Commits on Aug 24, 2025
- GH-605: pre review changes
  utkarshg6
  committed
  928d136
Commits on Sep 9, 2025
- GH-598-json-hotfix (#699)
  
  bertllll
  and
  Bert
  authored
  24e0a8a
Commits on Sep 11, 2025
- GH-605: review changes
  utkarshg6
  committed
  093d7de
- GH-605: eliminate new_fingerprints_recipient
  utkarshg6
  committed
  2fd4bcc
- GH-605: add commit hash to TODO
  utkarshg6
  committed
  44be81d
- GH-605: add TODOs for GH-703
  utkarshg6
  committed
  cc7da7a
- GH-605: refactor out the failed_tx
  utkarshg6
  committed
  d666e53
- GH-605: more review changes
  utkarshg6
  committed
  2450508
- GH-605: more refactoring of sql values
  utkarshg6
  committed
  bb1a67d
- GH-605: further fixes
  utkarshg6
  committed
  074a40b
- GH-605: more changes
  utkarshg6
  committed
  070123a
Commits on Sep 12, 2025
- GH-605: change it to retrieved_payables
  utkarshg6
  committed
  52034fb
- GH-605: rename to determine_next_scan_to_run
  utkarshg6
  committed
  8f63153
- GH-605: more changes
  utkarshg6
  committed
  1c2d773
- GH-605: improve the TODO
  utkarshg6
  committed
  e851f34
Commits on Sep 15, 2025
- GH-642: Redesigning PendingPayableScanner (#677)
  
  bertllll
  and
  Bert
  authored
  ca6cb36
- GH-689: Amend scanner scheduling: Handling ScanError msg (#691)
  
  bertllll
  and
  Bert
  authored
  6e020c7
Commits on Sep 16, 2025
- GH-605: add TODO for the test
  utkarshg6
  committed
  24396b1
- GH-606: Sweeping for ending the first stage (#706)
  
  bertllll
  and
  Bert
  authored
  647d61a
Commits on Sep 18, 2025
- GH-605: more and more changes
  utkarshg6
  committed
  d2fd9cd
- GH-605: bit more refactoring
  utkarshg6
  committed
  52411c9
- GH-605: bit more changes
  utkarshg6
  committed
  398bdd9
- GH-605: changing to & works
  utkarshg6
  committed
  e044dc4
- GH-605: further changes
  utkarshg6
  committed
  8227dc8
- GH-605: more TODOs
  utkarshg6
  committed
  ff6e400
Commits on Sep 19, 2025
- GH-605: derive Copy for PayableScanType
  utkarshg6
  committed
  dc863ef
- GH-605: add scan_type function
  utkarshg6
  committed
  9fd9ee7
- GH-605: comment out unused code in test
  utkarshg6
  committed
  9ba398e
- GH-605: refactor the code a bit
  utkarshg6
  committed
  80711d4
- GH-605: refactor signable_tx_templates_can_be_created_from_priced_retry_tx_templates
  utkarshg6
  committed
  4ac6418
- GH-605: the helper functions have more realistic args name
  utkarshg6
  committed
  83d6155
- GH-605: more refactoring of signable_tx_templates_can_be_created_from_priced_retry_tx_templates
  utkarshg6
  committed
  141d10a
- GH-605: more refactored changes
  utkarshg6
  committed
  4f91045
- GH-605: further refactoring changes
  utkarshg6
  committed
  896f7d0
- GH-605: handle_batch_results has been renamed
  utkarshg6
  committed
  18e0a54
Commits on Sep 20, 2025
- GH-605: few more changes
  utkarshg6
  committed
  cf0938a
- GH-605: few more changes
  utkarshg6
  committed
  9308d37
Commits on Sep 22, 2025
- GH-605: Review 4
  utkarshg6
  committed
  73395d8
- GH-605: Bug bot error
  utkarshg6
  committed
  7522708
Commits on Sep 23, 2025
- GH-605: Just merged; 567 errors
  utkarshg6
  committed
  e7c7716
Commits on Sep 24, 2025
- GH-605: reduced errors to 97
  utkarshg6
  committed
  794d23a
- GH-605: only 37 errors remaining
  utkarshg6
  committed
  655830d
Commits on Sep 25, 2025
- GH-605: only 5 errors remaining
  utkarshg6
  committed
  06106f7
- GH-605: only 2 errors remaining
  utkarshg6
  committed
  8947136
- GH-605: all errors gone
  utkarshg6
  committed
  b2df759
- GH-605: tests in sent_payable_dao are passing
  utkarshg6
  committed
  2828f80
Commits on Sep 26, 2025
- GH-605: all tests pass in payable scanner
  utkarshg6
  committed
  9a51af4
- GH-605: fix most of the clippy warnings
  utkarshg6
  committed
  663c30e
- GH-605: fix more of these problems
  utkarshg6
  committed
  6c84f82
- GH-605: write test for the ordering of ValidationStatus
  utkarshg6
  committed
  2f07581
- GH-605: implement ordering for ValidationStatus
  utkarshg6
  committed
  d6b8592
- GH-605: comment out unused code
  utkarshg6
  committed
  5838a52
- GH-605: more changes fixed
  utkarshg6
  committed
  eab920d
- GH-605: more fixing
  utkarshg6
  committed
  2cbdffe
- GH-605: interim commit
  
  Bert
  authored and
  Bert
  committed
  62f3542
Commits on Sep 27, 2025
- GH-605: all tests in Node passing
  
  Bert
  authored and
  Bert
  committed
  97f54c8
Commits on Sep 28, 2025
- GH-605: last todo removed
  
  Bert
  authored and
  Bert
  committed
  d94d5cb
- GH-605: fixed poor test coverage
  
  Bert
  authored and
  Bert
  committed
  b82e3d2
- GH-605: free of unnecessary boilerplate code - erased manual impls for PartialOrd and Ord
  
  Bert
  authored and
  Bert
  committed
  76a857c
Commits on Sep 29, 2025
- GH-605: continuous impovement -- Ord and little refactoring
  
  Bert
  authored and
  Bert
  committed
  b9ad935
- GH-605: CI except MNT just fine
  
  Bert
  authored and
  Bert
  committed
  00f0223
- GH-605: MNT fixed
  
  Bert
  authored and
  Bert
  committed
  15a4de1
- GH-605: small correction
  
  Bert
  authored and
  Bert
  committed
  02d98fb

Commits

Commits on Aug 24, 2025

Commits on Sep 9, 2025

Commits on Sep 11, 2025

Commits on Sep 12, 2025

Commits on Sep 15, 2025

Commits on Sep 16, 2025

Commits on Sep 18, 2025

Commits on Sep 19, 2025

Commits on Sep 20, 2025

Commits on Sep 22, 2025

Commits on Sep 23, 2025

Commits on Sep 24, 2025

Commits on Sep 25, 2025

Commits on Sep 26, 2025

Commits on Sep 27, 2025

Commits on Sep 28, 2025

Commits on Sep 29, 2025