Repository navigation
Show loading feedback during web OAuth sign-in - #1112
Merged
Merged
Conversation
Contributor
|
Maple development preview: https://37c9564b.maple-ca8.pages.dev Commit: Uses development API, billing, flags and PCR configuration. Cloudflare Access applies. |
AnthonyRonning
force-pushed
the
codex/oauth-button-loading
branch
2 times, most recently
from
October 9, 2026 05:29
dafc634 to
62a9312
Compare
Contributor
|
Maple Auth development preview: https://201fd34a.maple-auth-dev.pages.dev Commit: Uses development services. Cloudflare Access applies. Provider OAuth is not configured for PR URLs; use the stable Auth Dev host for OAuth rehearsal. |
AnthonyRonning
force-pushed
the
codex/oauth-button-loading
branch
from
October 9, 2026 06:44
62a9312 to
6b3134f
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple web sign-in left the ordinary login button visible while its popup was open and while the backend finished the callback. Login and sign-up now show a disabled spinner with “Signing in…” from the first click through navigation. Cancellation or failure restores the button.
Google and GitHub also show immediate progress while their web redirects are prepared, and restore their buttons when returning from the browser’s back-forward cache. Native entry flows, standalone Auth, SDKs, and backend configuration are unchanged.
Validation:
Full frontend formatting, lint (existing warnings only), TypeScript, and 1,284 tests passed. Added deferred Apple initiation/callback coverage and cancellation/retry assertions.
Dev-profile web build passed. Built-preview browser check confirmed the Apple spinner and restoration after closing its popup. No new end-to-end provider login is claimed for this UI change; localhost is not a registered Apple callback.
Used the repository-pinned Bun 1.3.5 and Node 24.12.0 from the lightweight Nix Pages shell with dependencies cloned from an identical package/lockfile. The full CI shell could not finish provisioning because the VM ran out of disk space. Equivalent frontend gates were run directly before committing.
Fresh hosted CI at
62a93125passed all 14 applicable checks, including frontend checks, web/preview builds, Auth CI and full repository checks; 24 unrelated jobs were skipped by their existing selectors.Runner prerequisite #1113 is merged. Refreshed onto master
0d7e4e2bat6b3134f0; range-diff confirms the application patch is unchanged. Fresh checks will run on the rebased commit.