Repository navigation
fix: build Linux RPM once with correct updater identity - #1132
Merged
Merged
Conversation
Contributor
|
Maple Auth development preview: https://8c176241.maple-auth-dev.pages.dev Commit: Uses development services. Cloudflare Access applies. Provider OAuth is not configured for PR URLs; use the stable Auth Dev host for OAuth rehearsal. |
Contributor
|
Maple development preview: https://e04c94e6.maple-ca8.pages.dev Commit: Uses development API, billing, flags and PCR configuration. Cloudflare Access applies. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published RPM contains a DEB-marked executable because Linux normalization copies the DEB payload into the final RPM. Tauri then selects the DEB update and invokes
dpkgon RPM installations. The initial Tauri RPM is also discarded after spending minutes building it.Generate AppImage and DEB through Tauri, then create the final RPM once with its existing normalization factory. Correct only the RPM staging executable's package marker, and check AppImage/DEB/RPM identity in both producer and downloaded-artifact verification. Extraction, RPM build and final-move failures must propagate rather than being hidden by temporary-file cleanup.
Updater service/routes/metadata, package filenames, final signing order, release triggers and publication remain unchanged. Existing affected RPM clients will need one manual installation of a corrected release before subsequent in-app updates can use RPM.
Validation: all 12 native aarch64-darwin flake checks and all 462 repository hook tests passed, including 10 focused identity/staging/failure tests. Independent diff review found no blocker. A private copy of the verified v3.4.3 executable changed only the three DEB-to-RPM marker bytes and retained its file mode. The actual Linux PR build passed in 9m20s: Tauri produced AppImage/DEB only, the factory built one RPM, all three final package identities and fixture updater signatures passed, and artifacts uploaded. All 18 applicable PR workflows passed: 38 successful jobs and 13 intentional skips. Independent signed master/release consumption has not run for this head. No Fedora installation/update, stable release or production publication was performed.
Fixes #1060