fix(agent-tools): give the payload-read fixtures the cutAttributeBytes column - #1169
JeremyFunk wants to merge 2 commits into
Conversation
…s column #1148's last commit added cutAttributeBytes to aiToolErrorPayloadsRowSchema, but the MCP and internal-API fixtures that answer the payload read still returned rows without it, so every decode failed the row schema.
Maple review🟢 Confidence 5/5 · safe to merge Adds
What was checked
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughTwo test payload fixtures now include an empty ChangesPayload fixture updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to These fixture updates do not change runtime behavior, and byte-count fallback coverage remains in place. No actionable merge-blocking risk is evident. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Maple reviewNothing to review The PR adds What was checked
|
Main is red since #1148 (run 36651793700), which blocked the prod deploy (run 36652303690).
cutAttributeBytestoaiToolErrorPayloadsRowSchema. Two fixtures that answer the payload read still returned rows without it, so decoding failed with "Compiled query row 0 did not match its declared output schema":apps/ai/src/mcp/tools/__tests__/agent-tools.test.ts(6 tests, lane small-2)apps/api/src/routes/internal/ai-sessions.http.test.ts(1 test, lane small-1)cutAttributeBytes: {}to both fixtures. None of their values goes overAI_TOOL_ERROR_ATTRIBUTE_MAX(16 384), so the real query would return an empty map too. The schema is unchanged.Tests:
agent-tools.test.ts(19/19),ai-sessions.http.test.ts(49/49),ai-tools.test.ts(42/42).Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by CodeRabbit
cutAttributeBytesfield.