Skip to content

fix(effect-sdk): cap the effect peer below rc.118 - #1179

Merged
JeremyFunk merged 1 commit into
mainfrom
fix/effect-sdk-peer-cap
Sep 30, 2026
Merged

JeremyFunk merged 1 commit into
mainfrom
fix/effect-sdk-peer-cap

Conversation

@JeremyFunk

@JeremyFunk JeremyFunk commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Effect 4.0.0-rc.118 removed the effect/unstable/{http,observability} paths the SDK imports. The open-ended peer (>=4.0.0-rc.113) let installs succeed and then fail with ERR_MODULE_NOT_FOUND at import.

  • Peer effect → >=4.0.0-rc.113 <4.0.0-rc.118, so package managers flag rc.118 at install time
  • bun.lock updated for the peer change

The SDK stays on the same Effect version as the monorepo, which can't move to rc.118 until alchemy (beta.79) and @maple-dev/effect-clickhouse stop importing effect/unstable/*. Supersedes #1175.

After merge: publish 0.9.0. The published 0.8.2 calls Config.string/Config.redacted, which no longer exist from rc.113 on, so no working release is on npm today.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

rc.118 removed the effect/unstable/{http,observability} paths the SDK imports,
so the open-ended range let installs succeed and then fail at runtime. The
monorepo stays on rc.117 until alchemy and effect-clickhouse support rc.118.
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: fc531590-382a-475c-b504-87727cd0246b

📥 Commits

Reviewing files that changed from the base of the PR and between 2e91012 and 38389dd.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • packages/effect-sdk/package.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@maple-review-bot

maple-review-bot Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 5/5 · safe to merge
One-line peer bound plus its lockfile mirror; the range admits exactly the Effect pre-releases the SDK still supports.
quality 100/100 · no findings · tests not needed · risk low

Caps the @maple-dev/effect-sdk effect peer at >=4.0.0-rc.113 <4.0.0-rc.118 so rc.118 installs fail at resolve time instead of ERR_MODULE_NOT_FOUND at import, and mirrors it in bun.lock. Config-only, safe to merge.

  • effect peer of @maple-dev/effect-sdk now bounded below 4.0.0-rc.118
  • bun.lock peer entry updated to match
What was checked
  • Peer range keeps the workspace on the cabal effect 4.0.0-rc.117, which satisfies both comparators (root package.json:92-100)
  • The two prerelease comparators make rc.113-rc.117 satisfy the range and rc.118 fail, so the bound does what the title claims
  • All in-repo consumers of the SDK use effect: catalog:effect, so no workspace package breaks on the tighter peer

38389dd · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

@JeremyFunk
JeremyFunk merged commit 1bc3d7a into main Sep 30, 2026
42 checks passed
@JeremyFunk
JeremyFunk deleted the fix/effect-sdk-peer-cap branch September 30, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant