Skip to content

fix(warehouse): read the current semconv key wherever we only read the legacy one - #1190

Merged
Makisuo merged 6 commits into
mainfrom
fix/semconv-current-key-reads
Sep 30, 2026
Merged

Makisuo merged 6 commits into
mainfrom
fix/semconv-current-key-reads

fix(ui): tone rpc.response.status_code only for gRPC rows

0e1ad0e
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Sep 30, 2026 in 32s

Confidence 5/5 · No issues found

🟢 Confidence 5/5 · safe to merge
The gRPC-only tone gate and its row-level rpc.system.name read are pinned by the new test, and the tone helper is only reached through pickImportantAttributes.
quality 100/100 · no findings · tests covered · risk low

The head commit gates the rpc.response.status_code chip tone on the row's rpc.system.name (legacy rpc.system fallback), so a gRPC-looking value from another RPC system stays neutral. Contained UI-helper change with a test that fails without the gate.

  • getChipTone takes an optional rpcSystem and tones rpc.response.status_code only for gRPC
  • pickImportantAttributes reads rpc.system.name (or rpc.system) from the row and passes it to every chip
What was checked
  • GRPC_CODES membership: OK and 0 excluded, 1 (CANCELLED) warns, non-gRPC values fall through to muted (log-attributes.ts:138-142)
  • getChipTone is reached only via pickImportantAttributes; apps/web/src/lib/log-attributes.ts re-exports @maple/ui, so no app keeps the old call
  • The new test fails against the pre-commit behavior: getChipTone("rpc.response.status_code", "2", "INFO") would be error, not muted

0e1ad0e · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.