Repository navigation
Misc fixes - #1987
Merged
Merged
Misc fixes#1987
Conversation
handle this set. 2. wrong call to method ``Import.self.eval_element_list`` in importexport 3. `SameQ.eval_list` must be `SameQ.eval` to overwrite the parent class. 4. Literal `ExpressionPattern`s should be ordered by the Expression element_order. 5. Orderless expressions mark themselves as `isliteral` when they are.
Member
|
LGTM |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some hidden issues I discovered when I started playing with the order of rules.
Element[elem_,Algebraic]since sympy does not handle this set.Import.self.eval_element_listin importexportSameQ.eval_listmust beSameQ.evalto overwrite the parent class.ExpressionPatternobjects should be ordered by the Expression element_order.isliteralwhen they are.