Repository navigation
fix(lint): CONV020 scopes to all modules by default and counts page actions as feedback (#229 #245) - #254
Closed
MendixMau wants to merge 1 commit into
Closed
fix(lint): CONV020 scopes to all modules by default and counts page actions as feedback (#229 #245)#254MendixMau wants to merge 1 commit into
MendixMau wants to merge 1 commit into
Conversation
…ck (#229, #245) PROJECT_MODULES defaults to "*" (all modules the lint run includes, vendor list excluded by lint-gate) so a fresh install is no longer inert. ShowPage/ClosePage/ShowHomePage count as feedback (presence only; action_type strings verified against the mxcli catalog builder). lint-gate --update-baseline drops _rule findings. Install-time module derivation not done: the existing vendor-exclusion mechanism makes it unnecessary. Checks: bash -n lint-gate.sh, tests/test-lint-delivery.sh (ALL GREEN, updated for the new default), test-stock-hashes.sh (16/0), leak guard, portability, check-scripts. Starlark behaviour fixture NOT added/run: no mxcli binary or rule runner in this repo. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
5 tasks done
MendixMau
added a commit
that referenced
this pull request
Oct 8, 2026
Squash of integration/2026-10-08, which merges: - #225 perf(ui-loop): test-stack-up.sh recognises a live mxcli run --local - #231 fix(sync): sync-project.sh no longer exits 1 silently before its bin/ refresh - #242 fix(init): local by default, no Dev Container - #243 docs(lint): process/lint-backlog.md, the lint rollout plan - #247 new(lint): the lint gate keeps a ledger - #249 learn(test): skills/e2e-locators-that-lie.md - #250 learn(skills): unhappy-path-testing.md - #251 fix(testing-shape): mxcli test --local shares the deploy directory (#230) - #252 fix(obligations): LOOK staleness reads the newest VALID AT stamp (#155) - #253 docs(lint): quality-source review, Batch 4 backlog rows and skill additions - #254 fix(lint): CONV020 works out of the box, page navigation counts as feedback (#229, #245) - #255 fix(e2e): journey-runner rung 2 runs for a negative-only span claim (#150) - #256 fix(gates): Stage 6 Surface, source-sufficiency title, ${JOURNEY_DIR} manifest token (#233, #234, #235) Verified on the branch: tests/run-tests.sh 33/0, tests/test-lint-delivery.sh ALL GREEN, tests/wave2 73/75 (two environmental), render-routing --check, check-scripts, check-portability, leak guard, check-no-private-citations, check-pr-discipline all clean; scaffold smoke run without crashes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
Owner
Author
|
Merged into master via integration PR #258 (squash 9dd9be4), on the maintainer's approval. Closing this PR; its branch is part of that squash. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
PROJECT_MODULESinlint-rules/conv020_action_user_feedback.stardefaults to"*"(every module the lint run includes; vendor modules are already excluded through.claude/lint-vendor-modules.txt, whichlint-gate.shpasses as-e). An empty tuple still emits the_ruleguard finding.project-bin/lint-gate.sh --update-baselineno longer writes_ruleblindness findings into the baseline, so a blind rule stays visible as PASS-BLIND.ShowPageAction,ClosePageActionandShowHomePageActionnow count as user feedback (presence, not order). The action-type strings were checked against the mxcli catalog source. Refresh-in-client is not exposed by mxcli's lint API; that stays an upstream ask and is noted in the rule header and README.tests/test-lint-delivery.shstep 8 sed updated for the new default.Install-time module derivation from the #229 proposal was dropped on purpose:
"*"plus the existing vendor exclusion covers it without installer logic.Field evidence
None yet. CONV020 is configurable and not in STOCK-HASHES. The rule's Starlark behaviour needs a run on a real project (laptop) before promotion; this PR only fixes the fresh-install defaults.
Checklist
tests/test-lint-delivery.shALL GREEN;test-stock-hashes.sh16/0 with the binary tier skipped)_rule🤖 Generated with Claude Code
https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
Generated by Claude Code