Repository navigation
Conversation
…233 #234 #235) #233: new test_surface_hit() in gate-check.sh is the one test behind check_stage_6 and the Surface column, so the harness pair (docs/verification/report.html + docs/report.json) no longer reads MISSING while the gate passes. #234: source-sufficiency report title uses realpath basename, so "." / trailing slash no longer yield an empty or "." title. #235: artifact-manifest.tsv accepts a ${JOURNEY_DIR} token; artifact-check.sh resolves it via project-bin/_common.sh (env > toolkit.env > ~/.mxcli-toolkit.env > journeys/), relative or absolute. Ad-hoc checked: default, relative env, absolute env, toolkit.env file. No golden-input capture applies (no parser added). Checks: bash -n; check-portability, check-no-client-data (leak guard), check-scripts, check-pr-discipline; fixtures test-source-sufficiency (51/0), test-source-sufficiency-gate (7/0), test-bug03-gates (31/0), test-wrong-verdicts (20/0). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
5 tasks done
MendixMau
added a commit
that referenced
this pull request
Oct 8, 2026
Squash of integration/2026-10-08, which merges: - #225 perf(ui-loop): test-stack-up.sh recognises a live mxcli run --local - #231 fix(sync): sync-project.sh no longer exits 1 silently before its bin/ refresh - #242 fix(init): local by default, no Dev Container - #243 docs(lint): process/lint-backlog.md, the lint rollout plan - #247 new(lint): the lint gate keeps a ledger - #249 learn(test): skills/e2e-locators-that-lie.md - #250 learn(skills): unhappy-path-testing.md - #251 fix(testing-shape): mxcli test --local shares the deploy directory (#230) - #252 fix(obligations): LOOK staleness reads the newest VALID AT stamp (#155) - #253 docs(lint): quality-source review, Batch 4 backlog rows and skill additions - #254 fix(lint): CONV020 works out of the box, page navigation counts as feedback (#229, #245) - #255 fix(e2e): journey-runner rung 2 runs for a negative-only span claim (#150) - #256 fix(gates): Stage 6 Surface, source-sufficiency title, ${JOURNEY_DIR} manifest token (#233, #234, #235) Verified on the branch: tests/run-tests.sh 33/0, tests/test-lint-delivery.sh ALL GREEN, tests/wave2 73/75 (two environmental), render-routing --check, check-scripts, check-portability, leak guard, check-no-private-citations, check-pr-discipline all clean; scaffold smoke run without crashes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
Owner
Author
|
Merged into master via integration PR #258 (squash 9dd9be4), on the maintainer's approval. Closing this PR; its branch is part of that squash. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
bin/gate-check.sh: newtest_surface_hit()accepts any of the four test-report.html locations or the harness pair (docs/verification/report.html plus docs/report.json).check_stage_6and the Stage 6 Surface column both call it, so the gate and the dashboard can no longer disagree..(T-225) #234bin/source-sufficiency.sh: the report title usesos.path.basename(os.path.realpath(PROJECT_DIR)), so.or a trailing slash no longer gives an empty or "." title.bin/lib/artifact-manifest.tsv+bin/lib/artifact-check.sh: the journeys row uses${JOURNEY_DIR}/*.journey.json. A new_art_journey_dirresolves it the way verify-module.sh does (env, then .claude/toolkit.env, then ~/.mxcli-toolkit.env, thenjourneys), and_art_findsubstitutes the token and accepts an absolute pattern for a journey dir outside the root.Field evidence
Field run 2026-10-08, existing app: the gate and the Surface column disagreed on the harness report, the title read "." for
gate-check.sh . 6, and the journeys artifact reported PENDING while the journeys obligation passed.Checklist
${JOURNEY_DIR}resolver was checked ad hoc for default, relative env, absolute env and toolkit.env values. No new fixture for the harness-pair case or the title.🤖 Generated with Claude Code
https://claude.ai/code/session_01VJgWP5vEoAsNsJYqCDMGNw
Generated by Claude Code