-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add PFX token metadata and logo for Sepolia #1978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kassahunyegetaneh-gif
wants to merge
6
commits into
MetaMask:master
Choose a base branch
from
kassahunyegetaneh-gif:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
11b0fff
Add PFX token metadata
kassahunyegetaneh-gif e72e81d
Update PFX token metadata
kassahunyegetaneh-gif 53f8c65
Create Sepolia icon folder
kassahunyegetaneh-gif d041c15
Add PFX token logo
kassahunyegetaneh-gif 9cc2604
Rename logo.png to erc20:0xB8F48a2B584C0fb27c920C46e0d1E168D70eeeDE.png
kassahunyegetaneh-gif 530774a
Fix PFX contract metadata filename
kassahunyegetaneh-gif File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "name": "Phila Forex Trading", | ||
| "symbol": "PFX", | ||
| "decimals": 18, | ||
| "erc20": true, | ||
| "logo": "./icons/eip155:11155111/erc20:0xB8F48a2B584C0fb27c920C46e0d1E168D70eeeDE.png" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
|
|
Binary file added
BIN
+1.31 MB
icons/eip155:11155111/erc20:0xB8F48a2B584C0fb27c920C46e0d1E168D70eeeDE.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metadata file placed in wrong path
High Severity
The PFX metadata file sits at the repository root as
0xB8F48a2B584C0fb27c920C46e0d1E168D70eeeDE.json, sobuildindex.jsnever loads it. The token is omitted from the contract map and will not appear for consumers.Reviewed by Cursor Bugbot for commit 530774a. Configure here.