Keep translations intact in Windows builds - #500
Merged
SkyBlade1978 merged 1 commit intoOct 5, 2026
Merged
SkyBlade1978 merged 1 commit into
SkyBlade1978 merged 1 commit into
Conversation
Use UTF-8 for archive filters and resource processing. Check every packaged language file against its source text before accepting a release jar.
SkyBlade1978
merged commit Oct 5, 2026
713802f
into
MinecraftModDevelopmentMods:master-1.14.4
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows used its default character encoding when the jar's line-ending filter read translated text. That damaged some Spanish, Japanese, Russian and Chinese strings even though the source files were valid UTF-8. Linux builds were unaffected.
Use UTF-8 explicitly for archive filtering and resource processing. The release audit now compares all 18 packaged language files with their source translations, so a build cannot silently change them.
The new check failed against the old Windows-built jar and passed after the fix. Unit tests, release auditing, Eclipse/IntelliJ launch checks and two identical clean builds also passed locally. No gameplay or registry changes are included.