Repository navigation
Conversation
added 9 commits
October 9, 2026 01:06
Names with & < or " produced an invalid modsettings.lsx.
Extraction overwrites existing files and keeps Packed/Tools subfolders. Download uses a timeout, picks the .zip asset, checks GitHub's sha256 digest and always closes its progress dialog.
A cached path kept writing the first profile's file after a switch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Baldur's Gate 3: bug fixes
Fixes in the BG3 plugin. Each one has a unit test under
tests/, run withpython -m unittest.&,<,>or quotes produce valid XML.modsettings.lsxpath follows the current profile..zipasset, checks GitHub's sha256 digest, uses a network timeout and overwrites old tools on update.bg3.exeandbg3_dx11.exeonly, not the Larian Launcher.modsettings.lsxmapping, and mappings are built per call.isinstancechecks, closed file handles in the diff log, and an explicitis_fileflag forcreate_dir_if_needed.Follow-up PRs
Three more PRs build on this one and open after it merges. Each link shows only that branch's own commits.
meta.lsxand file lists in Python, and uses Divine only for Zstd, solid or corrupt paks. Adds an Extract Pak tool, and runs Divine with an argument list and a timeout.meta.ini. Cancel aborts the launch, LSLib downloads only when a pak needs Divine, and the cache stores each pak's size and mtime.modsettings.lsx, and an Import Game Mods tool.