Skip to content

Switch to sys.base_prefix and add sanity check for Lib path detection #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Linus-XZX wants to merge 4 commits into
base: master
Choose a base branch
from
+2 −1
Open

Switch to sys.base_prefix and add sanity check for Lib path detection #160

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ad75fb
Switch to sys.base_prefix for better Lib path detection
Linus-XZX Aug 23, 2026
387ae46
Add basic sanity check for pythoncore.zip
Linus-XZX Oct 16, 2026
5c6e245
[pre-commit.ci] Auto fixes from pre-commit.com hooks.
pre-commit-ci[bot] Oct 16, 2026
f26e22e
Add message for new assertion
Linus-XZX Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/proxy/build_pythoncore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@

_EXCLUDE_MODULES = ["ensurepip", "idlelib", "test", "tkinter", "turtle_demo", "venv"]

libdir = Path(sys.executable).parent.joinpath("Lib")
libdir = Path(sys.base_prefix).joinpath("Lib")
assert libdir.exists()

with zipfile.PyZipFile(sys.argv[1], optimize=2, mode="w") as fp:
fp.writepy(libdir) # pyright: ignore[reportArgumentType]
for path in libdir.iterdir():
if path.is_dir() and path.name not in _EXCLUDE_MODULES:
fp.writepy(path) # pyright: ignore[reportArgumentType]
assert fp.namelist(), "Generated pythoncore.zip is empty. This will not block the build but will break MO2 at runtime!"