Repository navigation
fix: use explicit void parameter lists for no-argument C functions - #220
Merged
Merged
Conversation
Update the lifecycle API, internal helpers and test entry points consistently. Keep call sites unchanged so pre-C23 consumers receive proper prototypes. Refs Morcules#218
Morcules
marked this pull request as ready for review
October 11, 2026 12:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #218. Replace all 19 empty no-argument parameter lists in the C source and tests with
(void), including both public lifecycle declarations and their definitions, internal helpers, and test entry points. Call sites and function bodies are unchanged. This gives pre-C23 C consumers actual zero-argument prototypes instead of unspecified parameter lists.Validation performed locally with Clang/LLVM-MinGW:
-std=c17 -Wstrict-prototypes -Werror -fsyntax-only, the original declarations fail and the changed declarations plus valid no-argument calls pass.git diff --checkpasses.The full library and network integration suite were not run on this Windows host: the project targets macOS/Linux, and the existing workflow uses a self-hosted macOS ARM64 runner. This is a draft per CONTRIBUTING.md, pending that build/integration validation. No claim of C17 compatibility for the rest of the C23 code is intended.
AI-assisted change; reviewed and checked as described above.