Skip to content

fix #74 : 使得OOBE屏幕可以最大化、可以缩放 - #76

Merged
clansty merged 1 commit into
MuNET-OSS:mainfrom
Starrah:issue-74
Oct 9, 2026
Merged

clansty merged 1 commit into
MuNET-OSS:mainfrom
Starrah:issue-74

Conversation

@Starrah

@Starrah Starrah commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

尝试解决 #74 中提到的问题。

  1. 使得OOBE窗口本身,可以最大化,可以缩放。这样不管怎么样,用户总可以自己缩放。
  2. 使得OOBE的四个界面,全部包裹在可以滚动的容器里,这样可以滚动。

方法可能算是有点暴力,我也不知道是不是最好的方案,如果有更好的方案可以一块讨论。

View guided diff

Sourcery 摘要

使 OOBE 窗口可调整大小,并确保每个设置屏幕都能通过滚动保持可用。

新功能:

  • 允许调整 OOBE 窗口大小并将其最大化,同时设置支持的最小尺寸。
  • 在所有 OOBE 屏幕中启用滚动,以便在较小窗口中仍能访问其中的内容。

错误修复:

  • 修复 OOBE 布局在可用窗口尺寸不足时可能隐藏完成按钮或导航按钮等控件的问题。
Original summary in English

Summary by Sourcery

Make the OOBE window resizable and ensure every setup screen remains usable through scrolling.

New Features:

  • Allow the OOBE window to be resized and maximized, with a minimum supported size.
  • Enable scrolling across all OOBE screens so their content remains accessible in smaller windows.

Bug Fixes:

  • Fix OOBE layouts that could hide controls such as completion or navigation buttons when the available window size was insufficient.

@sourcery-ai

sourcery-ai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

审查者指南

该 PR 通过允许主窗口调整大小/最大化,并将全部四个 OOBE 页面放置在垂直可滚动的响应式容器中,改善了受限屏幕上的 OOBE 可用性。

文件级变更

变更 详细信息 文件
允许在受限的最小尺寸下调整和最大化 OOBE 窗口。
  • 将 WinForms 边框样式从固定切换为可调整大小。
  • 启用最大化按钮,并将最小客户区大小设置为 480×480。
MaiChartManager/OobeBrowser.cs
确保每个 OOBE 步骤在内容超出可用视口时仍然可用。
  • 将每个页面包装在占满可用区域的垂直滚动容器中。
  • 使用响应式内边距和最小高度的 flex 布局,在允许滚动的同时保持居中展示效果。
  • 添加底部间距,确保滚动到边界附近时控件仍然可访问。
MaiChartManager/Front/src/views/Oobe/GameDirPage.tsx
MaiChartManager/Front/src/views/Oobe/ModeSelectPage.tsx
MaiChartManager/Front/src/views/Oobe/ServerRunningPage.tsx
MaiChartManager/Front/src/views/Oobe/WelcomePage.tsx

可能相关的问题


提示和命令

与 Sourcery 交互

  • 触发新的审查: 在拉取请求中评论 @sourcery-ai review。
  • 继续讨论: 直接回复 Sourcery 的审查评论。
  • 根据审查评论生成 GitHub issue: 回复审查评论,请 Sourcery 根据该评论创建 issue。你也可以使用 @sourcery-ai issue 回复审查评论,以根据该评论创建 issue。
  • 生成拉取请求标题: 在拉取请求标题的任意位置写入 @sourcery-ai,即可随时生成标题。你也可以在拉取请求中评论 @sourcery-ai title,以随时(重新)生成标题。
  • 生成拉取请求摘要: 在拉取请求正文的任意位置写入 @sourcery-ai summary,即可在指定位置随时生成 PR 摘要。你也可以在拉取请求中评论 @sourcery-ai summary,以随时(重新)生成摘要。
  • 生成审查者指南: 在拉取请求中评论 @sourcery-ai guide,即可随时(重新)生成审查者指南。
  • 解决所有 Sourcery 评论: 在拉取请求中评论 @sourcery-ai resolve,即可解决所有 Sourcery 评论。如果你已经处理完所有评论且不想再看到它们,这会很有用。
  • 忽略所有 Sourcery 审查: 在拉取请求中评论 @sourcery-ai dismiss,即可忽略所有现有的 Sourcery 审查。如果你想从新的审查开始,这尤其有用——别忘了评论 @sourcery-ai review 以触发新的审查!

自定义你的使用体验

访问你的控制面板以:

  • 启用或禁用审查功能,例如 Sourcery 生成的拉取请求摘要、审查者指南等。
  • 更改审查语言。
  • 添加、删除或编辑自定义审查说明。
  • 调整其他审查设置。

获取帮助

Original review guide in English

Reviewer's Guide

The PR addresses OOBE usability on constrained screens by allowing the host window to resize/maximize and by placing all four OOBE pages inside vertically scrollable, responsive containers.

File-Level Changes

Change Details Files
Enable the OOBE window to be resized and maximized within a constrained minimum size.
  • Switch the WinForms border style from fixed to sizable.
  • Enable the maximize box and set a 480×480 minimum client size.
MaiChartManager/OobeBrowser.cs
Make every OOBE step usable when its content exceeds the available viewport.
  • Wrap each page in a full-area vertical scroll container.
  • Use responsive padding and a minimum-height flex layout to preserve centered presentation while allowing scrolling.
  • Add bottom spacing to keep controls accessible near the scroll boundary.
MaiChartManager/Front/src/views/Oobe/GameDirPage.tsx
MaiChartManager/Front/src/views/Oobe/ModeSelectPage.tsx
MaiChartManager/Front/src/views/Oobe/ServerRunningPage.tsx
MaiChartManager/Front/src/views/Oobe/WelcomePage.tsx

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@clansty
clansty merged commit c6cbf69 into MuNET-OSS:main Oct 9, 2026
3 checks passed

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嘿——我已经审查了你的更改,看起来很棒!

Sourcery 评估

已批准。


Sourcery 对开源项目免费——如果你喜欢我们的评审,请考虑分享它们 ✨
Original comment in English

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@Starrah
Starrah deleted the issue-74 branch October 9, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants