Repository navigation
[FEATURE] Add support for from keyword in parseColorFunction - #1639
Merged
oliverklee merged 4 commits intoSep 26, 2026
Conversation
samuil-banti-wpenigne
marked this pull request as ready for review
September 25, 2026 10:53
JakeQZ
reviewed
Sep 25, 2026
JakeQZ
left a comment
Collaborator
There was a problem hiding this comment.
This looks excellent to me, and a perfect way of handling from for the time being, until we work out a way of getting it into the Color class.
I like the tests, particularly the nested one.
The only nitpick I have is the naming of a data provider. @oliverklee, do you have anything else to comment on?
@samuil-banti-wpenigne, thanks again for understanding the codebase and finding the best fix, and including a good suite of accompanying tests.
JakeQZ
reviewed
Sep 25, 2026
Co-authored-by: JakeQZ <jake@qzdesign.co.uk>
Co-authored-by: JakeQZ <jake@qzdesign.co.uk>
oliverklee
approved these changes
Sep 26, 2026
oliverklee
left a comment
Collaborator
There was a problem hiding this comment.
Beautiful! Thank you for contributing this, @samuil-banti-wpenigne!
from keyword in parseColorFunction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we pass values like
hsl( triggers Color::parseColorFunction()toparsePrimitiveValuemethod, the parsingfails.
The
fromkeyword is not recognized. Instead,Size::parse()is called, which seesfrat the start offromand matches it as thefr, creatingSize(0.0, 'fr').CSS example: