Repository navigation
beats: resolve the output hosts once instead of in every template - #559
Open
afeefghannam89 wants to merge 3 commits into
Open
afeefghannam89 wants to merge 3 commits into
afeefghannam89 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Beats templates worked out their own output hosts, nine times over, each with the same
elasticstack_full_stackbranch. They now readbeats_elasticsearch_hostsandbeats_logstash_hosts, set once inroles/beats/tasks/main.ymlthe way the kibana role doesit. A value the user sets wins. Otherwise, with
elasticstack_full_stacktrue, the role fillsthem from the inventory groups.
Two things that were not possible before:
Elasticsearch
elasticstack_full_stackis truebeats_target_hostsis removed. It fed both output types with one list and was ignored whileelasticstack_full_stackis true. Withelasticstack_full_stackfalse, the two variables areset directly, and the two Beats molecule scenarios now do that. Breaking, but the collection is
still 0.x.
The two
set_facttasks are taggedalways, so every run has the two lists. The preflightassert from #552 has the same tags as the configure tasks. It runs whenever a configuration gets
written and stops the run if a list is empty. A
--tags certificatesrun writes noconfiguration, so the assert does not run there. The rule behind this is now in
CONTRIBUTING.md.
Closes #557