Skip to content

Fixed an issue with the list_fsxn_* script, and added a PowerShell version of the warm_performnace_tier script. - #287

Open
kcantrel wants to merge 20 commits into
mainfrom
update_terraform_checks
Open

kcantrel wants to merge 20 commits into
mainfrom
update_terraform_checks

Conversation

@kcantrel

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
actions/actions/checkout 34e114876b0b11c390a56381ad16ebd13914f8d5 🟢 6.3
Details
CheckScoreReason
Maintained🟢 45 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 4
Code-Review🟢 10all changesets reviewed
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Binary-Artifacts🟢 10no binaries found in the repo
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Pinned-Dependencies🟢 3dependency not pinned by hash detected -- score normalized to 3
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Security-Policy🟢 9security policy file detected
Packaging⚠️ -1packaging workflow not detected
SAST🟢 10SAST tool is run on all commits
Branch-Protection🟢 6branch protection is not maximal on development and all release branches
actions/step-security/git-auto-commit-action 905c3cd6e9ed2b67b4d46ff401fdb6d745d0ff9d 🟢 8.1
Details
CheckScoreReason
Dependency-Update-Tool🟢 10update tool detected
Maintained🟢 1016 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 10
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Security-Policy🟢 10security policy file detected
Code-Review🟢 10all changesets reviewed
Binary-Artifacts🟢 10no binaries found in the repo
Packaging⚠️ -1packaging workflow not detected
Pinned-Dependencies🟢 6dependency not pinned by hash detected -- score normalized to 6
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Vulnerabilities🟢 100 existing vulnerabilities detected
SAST🟢 10SAST tool is run on all commits
Signed-Releases🟢 105 out of the last 5 releases have a total of 5 signed artifacts.
Fuzzing⚠️ 0project is not fuzzed
Branch-Protection🟢 8branch protection is not maximal on development and all release branches
Contributors🟢 6project has 2 contributing companies or organizations -- score normalized to 6
CI-Tests🟢 1013 out of 13 merged PRs checked by a CI test -- score normalized to 10
actions/step-security/harden-runner fa2e9d605c4eeb9fcad4c99c224cee0c6c7f3594 🟢 7.8
Details
CheckScoreReason
Binary-Artifacts🟢 10no binaries found in the repo
Branch-Protection🟢 8branch protection is not maximal on development and all release branches
CI-Tests🟢 106 out of 6 merged PRs checked by a CI test -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Code-Review🟢 10all changesets reviewed
Contributors🟢 6project has 2 contributing companies or organizations -- score normalized to 6
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Dependency-Update-Tool🟢 10update tool detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Maintained🟢 1030 commit(s) and 6 issue activity found in the last 90 days -- score normalized to 10
Packaging⚠️ -1packaging workflow not detected
Pinned-Dependencies🟢 6dependency not pinned by hash detected -- score normalized to 6
SAST🟢 9SAST tool detected but not run on all commits
Security-Policy🟢 10security policy file detected
Signed-Releases⚠️ -1no releases found
Token-Permissions🟢 10GitHub workflow tokens follow principle of least privilege
Vulnerabilities⚠️ 022 existing vulnerabilities detected

Scanned Files

  • .github/workflows/update-CloudformationTemplate-auto_create_sm_relationships.yml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Partial reads, suppressed failures, invalid parameter handling, and early watchdog timeouts can produce incomplete or incorrect operation.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds Windows support for warming FSx for ONTAP performance tiers and improves regional listing scripts.

Changes:

  • Adds a parallel PowerShell warming utility.
  • Supports comma-separated regions and responsive watchdogs.
  • Expands usage documentation.
File summaries
File Description
WarmPerformanceTier.ps1 Adds Windows warming implementation.
warm_performance_tier/README.md Documents Windows usage.
list_fsxn_volumes Adds multi-region parsing and watchdog polling.
list_fsxn_svms Adds multi-region parsing and watchdog polling.
list_fsxn_filesystems Adds multi-region parsing and watchdog polling.
Review details

Suppressed comments (1)

Management-Utilities/warm_performance_tier/README.md:136

  • Correct the heading typo from “Runing” to “Running.”
### Runing the script on a Windows based operating system
  • Files reviewed: 5/5 changed files
  • Comments generated: 13
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Management-Utilities/fsx-ontap-aws-cli-scripts/list_fsxn_filesystems Outdated
Comment thread Management-Utilities/fsx-ontap-aws-cli-scripts/list_fsxn_svms Outdated
Comment thread Management-Utilities/fsx-ontap-aws-cli-scripts/list_fsxn_volumes Outdated
Comment thread Management-Utilities/warm_performance_tier/WarmPerformanceTier.ps1
Comment thread Management-Utilities/warm_performance_tier/WarmPerformanceTier.ps1
Comment thread Management-Utilities/warm_performance_tier/WarmPerformanceTier.ps1
Comment thread Management-Utilities/fsx-ontap-aws-cli-scripts/list_fsxn_svms Outdated
Comment thread Management-Utilities/fsx-ontap-aws-cli-scripts/list_fsxn_volumes Outdated
Comment thread Management-Utilities/warm_performance_tier/README.md Outdated
Comment thread Management-Utilities/warm_performance_tier/README.md Outdated
@kcantrel
kcantrel requested a review from nichollri September 22, 2026 18:28
…ship exist. Added support for an S3 bucket to contain the partners and secrets information. Added a CloudFormation template.
…ship exist. Added support for an S3 bucket to contain the partners and secrets information. Added a CloudFormation template.
…ship exist. Added support for an S3 bucket to contain the partners and secrets information. Added a CloudFormation template.
…ship exist. Added support for an S3 bucket to contain the partners and secrets information. Added a CloudFormation template.
…ship exist. Added support for an S3 bucket to contain the partners and secrets information. Added a CloudFormation template.
…ship exist. Added support for an S3 bucket to contain the partners and secrets information. Added a CloudFormation template.
…ship exist. Added support for an S3 bucket to contain the partners and secrets information. Added a CloudFormation template.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Pagination, configuration, workflow-discovery, timeout, and CloudFormation defects can prevent correct deployment or leave volumes unprocessed.

Review effort: Balanced
Findings: 4 High severity · 8 Medium severity · 4 Low severity

Open (16)
Resolved since last review (13)

Comment thread Management-Utilities/auto_create_sm_relationships/auto_create_sm_relationships.py Outdated
Comment thread Management-Utilities/auto_create_sm_relationships/auto_create_sm_relationships.py Outdated
Comment thread Management-Utilities/auto_create_sm_relationships/cloudformation.yaml Outdated
Comment thread Management-Utilities/warm_performance_tier/WarmPerformanceTier.ps1
Comment thread Management-Utilities/auto_create_sm_relationships/README.md Outdated
Comment thread Management-Utilities/fsx-ontap-aws-cli-scripts/set_fsxn_password Outdated
Comment thread Management-Utilities/fsx-ontap-aws-cli-scripts/set_fsxn_password Outdated
Comment thread Management-Utilities/warm_performance_tier/README.md Outdated
…ship exist. Added support for an S3 bucket to contain the partners and secrets information. Added a CloudFormation template.
})
except Exception as err:
message = f'Error, unable to read the secrets and/or partners config tables "{config["dynamodbSecretsTableName"]}", "{config["dynamodbPartnersTableName"]}" from Dynamodb region {config["dynamodbRegion"]}. Error message: "{err}".'
logger.critical(message)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants