Skip to content

Fix Neuralynx unclosed recording header parsing - #1902

Open
Yi-111-a wants to merge 1 commit into
NeuralEnsemble:masterfrom
Yi-111-a:fix-neuralynx-unclosed-date
Open

Yi-111-a wants to merge 1 commit into
NeuralEnsemble:masterfrom
Yi-111-a:fix-neuralynx-unclosed-date

Conversation

@Yi-111-a

Copy link
Copy Markdown

Closes #1901

Summary

  • tolerate Neuralynx close headers containing the explicit File was not properly closed sentinel
  • leave recording_closed unavailable instead of passing the sentinel to dateutil.parser
  • add a focused regression test for the malformed close line

Testing

  • python -m pytest -q neo/test/rawiotest/test_neuralynxrawio.py::TestNlxHeaderParsing::test_unclosed_recording
  • python -m black --check neo/rawio/neuralynxrawio/nlxheader.py neo/test/rawiotest/test_neuralynxrawio.py

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Neuralynx DateTime incorrectly parsed

1 participant