Repository navigation
Replace editor attribute classes with attribute map and validation - #14936
Merged
Merged
Conversation
kriben
requested changes
Oct 16, 2026
kriben
requested changes
Oct 16, 2026
kriben
left a comment
Collaborator
There was a problem hiding this comment.
The seismic clip-value validator was removed without an equivalent replacement.
RimSeismicData and RimSeismicDifferenceData previously installed a QDoubleValidator(0.00001, infinity, 6) for m_userClipValue. Unlike the other migrated validators, neither a field range nor a map-based validator replaces it. The UI can therefore accept zero or negative clip values, after which updateDataRange() silently converts values <= 0 to the maximum data value.
Please restore equivalent validation, preferably centrally on the inherited pair-valued field while preserving its disabled 0.0 sentinel.
Verification performed:
git diff --checkpassedcafUserInterfacebuilt successfully- Full
ResInsightbuild succeeded
magnesj
force-pushed
the
validation-replace-line-editor-validators-review
branch
from
October 16, 2026 07:50
335dbbd to
02c8d62
Compare
…re seismic clip min
magnesj
force-pushed
the
validation-replace-line-editor-validators-review
branch
from
October 16, 2026 07:59
02c8d62 to
8b82c31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the per-editor
PdmUi*EditorAttributeclasses with a generic string-keyed attribute map onPdmUiItem(setAttribute/attribute/removeAttribute/attributeNames). Each editor declares its supported keys (Keysstruct andSUPPORTED_ATTRIBUTES), andPdmUiItem::validateAttributeswarns about unsupported keys. Line editor validators are replaced by attribute-based validation.Review guide
Commits are grouped by layer, so review them in order:
cafPdmUiCorecafUserInterfacecafTestApplicationupdates (AUTORCC, windeployqt)Intermediate commits may not build individually, because ApplicationLibCode depends on the removal of the caf attribute classes. Build and test the branch tip.
Testing