Repository navigation
ci: Pin Maven to 3.9.16 with the Maven Wrapper - #83
Closed
liamhughes wants to merge 1 commit into
Closed
liamhughes wants to merge 1 commit into
liamhughes wants to merge 1 commit into
Conversation
Bundles built with Maven 3.10.0 (ubuntu-latest image 20261004.327) include local-repository files that Maven Central rejects. Build with the wrapper instead of the runner image's Maven, and keep Renovate below 3.10 until central-publishing-maven-plugin is upgraded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Pre-release publishes have failed Maven Central validation since 7 October, when
ubuntu-latestimageubuntu24/20261004.327moved Maven from 3.9.16 to 3.10.0.central-publishing-maven-plugin0.8.0 stages artifacts with Maven's install mechanism, and under 3.10 that also writesmaven-metadata-local.xmland_remote.repositoriesinto the staging folder. Both end up incentral-bundle.zip, and Central rejects the bundle because the artifact folder has content without a.pom.This is an alternative to #82, which pins the same version with a download step in the composite action. Here the pin lives in the Maven Wrapper, so local builds use the same Maven as CI and Renovate can see the pin.
The long-term fix (upgrading the plugin and removing the pin) is a follow-up on the ticket.
Part of BMBB-1251.
Changes
only-script, so no jar is committed), pinned to Maven 3.9.16 withdistributionSha256Sum.build-test-pack-deploy/action.ymlto run./mvnwinstead ofmvn, and added aShow Maven versionstep that logs./mvnw -v.maven-wrappermanager torenovate-config.js, with a rule holdingorg.apache.maven:apache-mavento<3.10.0.CONTRIBUTING.mdto use./mvnwand dropped Maven from the prerequisites.Notes for review
maven-wrappermanager updatesdistributionSha256Sumalong with the version, so the checksum shouldn't go stale on bumps.Testing
./mvnw -vdownloads and runs Maven 3.9.16, and a wrongdistributionSha256Sumfails with a checksum error../mvnw -B clean deploy -Dgpg.skip=truelocally: 433 tests pass, and the bundle has 20 files (CI's 24 minus the.ascsignatures) with nomaven-metadata-local.xmlor_remote.repositories.