Skip to content

fix: require a key when creating or updating models - #220

Open
Joltras wants to merge 5 commits into
mainfrom
fix/require-model-key
Open

Joltras wants to merge 5 commits into
mainfrom
fix/require-model-key

Conversation

@Joltras

@Joltras Joltras commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Proposed changes

Models could be created without a key, which left entries in the database that the generator can't use. The key is now required when creating or updating attributes, fonts, items, sounds, advancements, dimensions and projects.Requests without a key are rejected with a 400 instead of being saved. Sound and font fields that were wrongly blocked can be set again.Added tests for the missing-key cases.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@Joltras
Joltras requested a review from TheMeinerLP October 12, 2026 19:37
@Joltras Joltras self-assigned this Oct 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test results

  138 files    138 suites   1m 9s ⏱️
  348 tests   339 ✅  9 💤 0 ❌
1 123 runs  1 048 ✅ 75 💤 0 ❌

Results for commit 9638310.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant