Repository navigation
MultiBackendJobManager: Dynamically add all usage metrics in job DB. … - #947
Merged
Merged
Conversation
…Remove hardcoded usage metrics from required columns
soxofaan
reviewed
Oct 1, 2026
soxofaan
left a comment
soxofaan
left a comment
Member
There was a problem hiding this comment.
some quick notes from superficial review
Contributor
|
Only thing I am a bit worried about, but I'd have to look into more thoroughly, is data type handling. If a users updates their openeo and loads in an old dataframe, will it give issues? |
… unit test for it
Collaborator
Author
|
Good call, there was one edge case where the job manager would fail: for an unfinished job database with the legacy columns present. I.e. when a user would update the python client version in the middle of processing. That should now also be handled + unit test added. Let's see if they pass. |
VictorVerhaert
approved these changes
Oct 5, 2026
Member
|
can you resolve the conflict on the changelog? |
…-usage-columns # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of hardcoded
memory,durationandcpumetrics, the MBJM now fetches all usage metrics from the job metadata and writes them to the job DB. This behaviour is more backend agnostic and doesn't require a change in the source code, each time we want a new metric in the job DB