Repository navigation
💄♻️:keep the masthead ring in one place - #1875
Conversation
The home page and the news page each carried the same eleven lines of `<svg>`, identical down to the byte, so a change to the ring meant finding both. Only the element moves. Each page keeps its own wrapper, which is what the stylesheets hook onto to size it -- 620px on the home page and 460px on the news page -- so the two go on looking different while being drawn from one file. The note about why it is the ring rather than the logogram went into the file it explains. It reaches a reader only in a development build, since the production one drops comments. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe home and news pages now load the ring graphic through the shared ChangesShared ring rendering
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change centralizes the masthead ring artwork while preserving each page’s wrapper and rendered size. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
home.htmlandnews.htmleach carried the same eleven lines of<svg>for the ring, identical down to the byte. Now they include onefile.
Only the element moves. Each page keeps its own wrapper
<div>, whichis what
_home.scssand_news.scsshook onto to size it, so the tworings go on looking different while being drawn from one file.
The note explaining why it is the ring rather than the logogram moved
into the file it is about. It lived in
home.htmlbefore and appliedto both.
Checked
nps test— all verify tasks pass.verify-svgruns prettier andvnu over every
.svgincluding_includes/, so the new file ischecked as real SVG; that is why the note is an SVG comment rather
than a Liquid one.
<svg>is unchanged inboth pages, differing only in indentation.
SVGO folds the element down to
<svg viewBox="0 0 100 100" xmlns="…"><circle …/></svg>.620×620 on the home page, 460×460 on the news page.
Summary by CodeRabbit