Skip to content

💄♻️:keep the masthead ring in one place - #1875

Merged
openinf-commit-queue[bot] merged 1 commit into
livefrom
refactor/share-the-ring
Aug 31, 2026
Merged

openinf-commit-queue[bot] merged 1 commit into
livefrom
refactor/share-the-ring

Conversation

@DerekNonGeneric

@DerekNonGeneric DerekNonGeneric commented Aug 31, 2026 •

Copy link
Copy Markdown
Member

home.html and news.html each carried the same eleven lines of
<svg> for the ring, identical down to the byte. Now they include one
file.

_includes/assets/img/ring.svg   new, 18 lines
collections/_pages/home.html    -19
collections/_pages/news.html    -14

Only the element moves. Each page keeps its own wrapper <div>, which
is what _home.scss and _news.scss hook onto to size it, so the two
rings go on looking different while being drawn from one file.

The note explaining why it is the ring rather than the logogram moved
into the file it is about. It lived in home.html before and applied
to both.

Checked

  • nps test — all verify tasks pass. verify-svg runs prettier and
    vnu over every .svg including _includes/, so the new file is
    checked as real SVG; that is why the note is an SVG comment rather
    than a Liquid one.
  • Rendered output diffed before and after: the <svg> is unchanged in
    both pages, differing only in indentation.
  • Production build drops the comment (0 occurrences in either page) and
    SVGO folds the element down to
    <svg viewBox="0 0 100 100" xmlns="…"><circle …/></svg>.
  • Both rings still render at their own sizes, measured in the browser:
    620×620 on the home page, 460×460 on the news page.

Summary by CodeRabbit

  • Refactor
    • Updated the home and news pages to use the shared ring graphic.
    • Removed duplicated inline graphic markup while preserving the existing visual appearance.

The home page and the news page each carried the same eleven lines of
`<svg>`, identical down to the byte, so a change to the ring meant
finding both.

Only the element moves. Each page keeps its own wrapper, which is what
the stylesheets hook onto to size it -- 620px on the home page and
460px on the news page -- so the two go on looking different while
being drawn from one file.

The note about why it is the ring rather than the logogram went into
the file it explains. It reaches a reader only in a development build,
since the production one drops comments.

Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Assisted-by: Claude-Code:claude-opus-5
@netlify

netlify Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for gh-pages-openinf ready!

Name Link
🔨 Latest commit d7ea7ed
🔍 Latest deploy log https://app.netlify.com/projects/gh-pages-openinf/deploys/6a95e2906ea2ad00098919fe
😎 Deploy Preview https://deploy-preview-1875--gh-pages-openinf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 2543c15a-eb8c-4ff7-8301-cc2168822fe6

📥 Commits

Reviewing files that changed from the base of the PR and between 27ebbcb and d7ea7ed.

⛔ Files ignored due to path filters (1)
  • _includes/assets/img/ring.svg is excluded by !**/*.svg
📒 Files selected for processing (2)
  • collections/_pages/home.html
  • collections/_pages/news.html

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The home and news pages now load the ring graphic through the shared assets/img/ring.svg include instead of embedding inline SVG markup.

Changes

Shared ring rendering

Layer / File(s) Summary
Replace inline ring markup
collections/_pages/home.html, collections/_pages/news.html
Both page templates use the shared assets/img/ring.svg include for the ring graphic.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to d7ea7

This change centralizes the masthead ring artwork while preserving each page’s wrapper and rendered size. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: centralizing the masthead ring SVG in one place. The emojis add minor noise but do not prevent understanding.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/share-the-ring

Comment @coderabbitai help to get the list of available commands.

@DerekNonGeneric DerekNonGeneric added the 🚀 Status: Commit Queue Land this pull request when its checks pass label Aug 31, 2026
@openinf-commit-queue
openinf-commit-queue Bot merged commit 5ae5b50 into live Aug 31, 2026
17 checks passed
@openinf-commit-queue openinf-commit-queue Bot removed the 🚀 Status: Commit Queue Land this pull request when its checks pass label Aug 31, 2026
@DerekNonGeneric
DerekNonGeneric deleted the refactor/share-the-ring branch September 6, 2026 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant