Repository navigation
💄♻️:draw the 404 action the way the site draws - #1878
Conversation
Bootstrap's button styles cost 10 KB to fill one rounded teal pill on one page, and the pill was the tell: this site draws in strokes. The ring is stroked rather than filled, a heading carries a rule beside it, a link carries an underline under it, and nothing anywhere is rounded. So the action is a square box with a 2px edge and no fill, labelled in the monospace uppercase the news chips use, with an arrow that slides back a little under the pointer the way the one on a post slides forward. Hovering or focusing it fills the box with ink and turns the label to parchment, which is the chip inverted. Both states read at 13.97:1. The wrapper sizes the ghosted numerals at 10rem, so the font size here is stated rather than inherited from it. `role='button'` went with the import. The element is a link that navigates, and saying otherwise told a screen reader to expect something that acts in place. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe 404 page replaces its Bootstrap button link with a custom Changes404 Error Page Styling
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR only restyles the 404 action and removes the final Bootstrap component import; the change is localized and validated, so no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Title checkExplanation The title describes the main change: redesigning the 404 action to match the site's visual style. It is somewhat informal and includes decorative emojis, but it remains clear and related to the changeset. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 Stylelint (17.14.0)_assets/styles/_error.scssConfigurationError: Could not find "stylelint-config-recess-order". Do you need to install the package or use the "configBasedir" option? Comment |
Drops the last Bootstrap component import and redraws the 404 action in
the site's own language.
85.1 KB, from 94.4 KB on
liveand 158.2 KB two changes ago — 46%off the original.
Why it looked foreign
buttonscost 10.0 KB to style a single.btnon/404/, and therounded teal fill was the tell. This site draws in strokes and hard
edges:
fill="none",stroke="currentColor".featured-link.featured-catchipNothing on the site is rounded, and nothing of consequence is a flat
fill. The button was both.
What it is now
A square box with a 2px edge and no fill, labelled in the same
monospace uppercase as the news chips, with a
←that slides backunder the pointer the way the
→on a post slides forward. Hover and:focus-visiblefill the box with ink and turn the label to parchment— the chip, inverted.
role="button"came off. It is a link that navigates, and the roletold assistive tech to expect something that acts in place.
Checked
nps test— all verify tasks pass.stylelintwanted a differentproperty order and
editorconfig-checkerwanted the commentcontinuation at two spaces; both settled with
format-scss, and thereorder was confirmed not to alter rendering.
live; the two thatdiffer are
/404/at each viewport, which is the point.:focus-visiblematches, and thefill applies once the 150ms transition settles.
prefers-reduced-motion: reducedrops both transitions, matchingwhat
_nav.scssand_home.scssalready do..btnrules remain in the built CSS.Summary by CodeRabbit
Style
Bug Fixes