Repository navigation
🏗️🔧:check the files the checks were skipping - #1891
Conversation
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe changes update repository quality-tool configuration. YAML tasks exclude the generated lockfile, spelling verification scans JSON5 and JSONC files, and an MD048 comment typo is corrected. ChangesQuality tooling configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to Quality-tooling file coverage is updated consistently, with generated lockfiles excluded from YAML checks and JSON5/JSONC included in spelling checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Ported from OpenINF/.github, where these are part of 7504c8a and e93b403. Two globs were not describing what they meant. The YAML tasks matched pnpm-lock.yaml, so every `verify.yaml` and `format.yaml` ran prettier over a 178 KB generated file. It is written by pnpm, not by hand, and a lockfile that failed a style check is not a thing anybody would fix by editing it. Excluded, the YAML tasks read ten files rather than eleven. The spelling glob named `json` but neither `json5` nor `jsonc`, so .renovaterc.json5, biome.jsonc, .markdownlint-cli2.jsonc and .markdownlint.jsonc were never spell-checked. Not a hypothetical gap: adding the two extensions took cspell from 123 files to 127 and turned up `syle` for `style` in a comment in .markdownlint.jsonc, which is fixed here. The same comment in OpenINF/.github is spelt correctly, so this was ours alone. One thing to watch when landing this alongside #1884: that branch passes the spelling glob to `matched()` as a second, literal copy of the same string. The two hunks are far enough apart to merge without complaint, and whichever lands second leaves the literal in `matched()` naming the older extension list. It reads only in a failure message, but it should be brought back into agreement. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
The follow-up this branch said it would need. #1884 landed first and brought `matched(files, ...)`, whose second argument was a second literal copy of the glob above it -- and the two were already a version apart, since this branch widened one of them to cover json5 and jsonc and the other still named the older list. It is read only in the message printed when nothing matched, so nothing was broken by it. But a string duplicated once has already shown it will drift, so it is named and referenced twice rather than written twice. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
0048ea8 to
b64d03f
Compare
Ported from
OpenINF/.github, where these are part of7504c8aande93b403.Two globs were not describing what they meant.
The YAML tasks matched
pnpm-lock.yaml. Everyverify.yamlandformat.yamlran prettier over a 178 KB generated file. It is written by pnpm, not by hand, and a lockfile that failed a style check is not a thing anybody would fix by editing it. Excluded, the YAML tasks read ten files rather than eleven.The spelling glob named
jsonbut neitherjson5norjsonc. So.renovaterc.json5,biome.jsonc,.markdownlint-cli2.jsoncand.markdownlint.jsoncwere never spell-checked.That gap was not hypothetical. Adding the two extensions took cspell from 123 files to 127 and immediately turned up
syleforstylein a comment in.markdownlint.jsonc, fixed here. The same comment inOpenINF/.githubis spelt correctly, so this one was ours alone.One thing to watch when landing this alongside #1884
That branch passes the spelling glob to
matched()as a second, literal copy of the same string:The two hunks are far enough apart that git merges them without complaint — I merged both locally to confirm — but whichever lands second leaves that literal naming the older extension list. It is read only in a failure message, so nothing breaks, but the two should be brought back into agreement in whichever PR lands last.
How it was checked
verify.spellingclean at 127 files after the typo fix.pnpm-lock.yaml.verify.all.Summary by CodeRabbit