Skip to content

🏗️🔧:check the files the checks were skipping - #1891

Merged
openinf-commit-queue[bot] merged 2 commits into
livefrom
infra/check-what-was-skipped
Sep 7, 2026
Merged

openinf-commit-queue[bot] merged 2 commits into
livefrom
infra/check-what-was-skipped

Conversation

@DerekNonGeneric

@DerekNonGeneric DerekNonGeneric commented Sep 7, 2026 •

Copy link
Copy Markdown
Member

Ported from OpenINF/.github, where these are part of 7504c8a and e93b403.

Two globs were not describing what they meant.

The YAML tasks matched pnpm-lock.yaml. Every verify.yaml and format.yaml ran prettier over a 178 KB generated file. It is written by pnpm, not by hand, and a lockfile that failed a style check is not a thing anybody would fix by editing it. Excluded, the YAML tasks read ten files rather than eleven.

The spelling glob named json but neither json5 nor jsonc. So .renovaterc.json5, biome.jsonc, .markdownlint-cli2.jsonc and .markdownlint.jsonc were never spell-checked.

That gap was not hypothetical. Adding the two extensions took cspell from 123 files to 127 and immediately turned up syle for style in a comment in .markdownlint.jsonc, fixed here. The same comment in OpenINF/.github is spelt correctly, so this one was ours alone.

One thing to watch when landing this alongside #1884

That branch passes the spelling glob to matched() as a second, literal copy of the same string:

process.exitCode = matched(
  files,
  '**/*.{md,html,liquid,scss,mts,mjs,json,yml,yaml,sh}'
)

The two hunks are far enough apart that git merges them without complaint — I merged both locally to confirm — but whichever lands second leaves that literal naming the older extension list. It is read only in a failure message, so nothing breaks, but the two should be brought back into agreement in whichever PR lands last.

How it was checked

  • verify.spelling clean at 127 files after the typo fix.
  • Confirmed the exclusion does what it says: the YAML glob returns 11 entries before and 10 after, the removed one being pnpm-lock.yaml.
  • No new failures across verify.all.

Summary by CodeRabbit

  • Chores
    • Improved formatting and verification workflows by excluding generated lockfiles from YAML processing.
    • Expanded spelling checks to include JSON5 and JSONC configuration files.
    • Spelling verification now reports when no matching files are available.
    • Corrected a spelling error in a code-fence style configuration comment.
    • Preserved existing configuration behavior while improving maintenance checks.

@netlify

netlify Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for gh-pages-openinf ready!

Name Link
🔨 Latest commit b64d03f
🔍 Latest deploy log https://app.netlify.com/projects/gh-pages-openinf/deploys/6a9e3808384dbe00072d5e0c
😎 Deploy Preview https://deploy-preview-1891--gh-pages-openinf.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 11151295-4006-49ee-9d14-46bf0e8da86f

📥 Commits

Reviewing files that changed from the base of the PR and between 0048ea8 and b64d03f.

📒 Files selected for processing (3)
  • build/tasks/format/format-yaml.mts
  • build/tasks/verify/verify-spelling.mts
  • build/tasks/verify/verify-yaml.mts

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The changes update repository quality-tool configuration. YAML tasks exclude the generated lockfile, spelling verification scans JSON5 and JSONC files, and an MD048 comment typo is corrected.

Changes

Quality tooling configuration

Layer / File(s) Summary
Validation scope and lint configuration
.markdownlint.jsonc, build/tasks/format/format-yaml.mts, build/tasks/verify/verify-spelling.mts, build/tasks/verify/verify-yaml.mts
YAML formatting and verification exclude pnpm-lock.yaml. Spelling verification uses a shared glob for JSON5 and JSONC files and exits with status 1 when no files match. The MD048 comment now uses “style”.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to b64d0

Quality-tooling file coverage is updated consistently, with generated lockfiles excluded from YAML checks and JSON5/JSONC included in spelling checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating check globs to include files that were previously skipped. It is understandable despite the decorative emojis and informal phrasing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch infra/check-what-was-skipped

Comment @coderabbitai help to get the list of available commands.

Ported from OpenINF/.github, where these are part of 7504c8a and
e93b403.

Two globs were not describing what they meant.

The YAML tasks matched pnpm-lock.yaml, so every `verify.yaml` and
`format.yaml` ran prettier over a 178 KB generated file. It is written
by pnpm, not by hand, and a lockfile that failed a style check is not a
thing anybody would fix by editing it. Excluded, the YAML tasks read
ten files rather than eleven.

The spelling glob named `json` but neither `json5` nor `jsonc`, so
.renovaterc.json5, biome.jsonc, .markdownlint-cli2.jsonc and
.markdownlint.jsonc were never spell-checked. Not a hypothetical gap:
adding the two extensions took cspell from 123 files to 127 and turned
up `syle` for `style` in a comment in .markdownlint.jsonc, which is
fixed here. The same comment in OpenINF/.github is spelt correctly, so
this was ours alone.

One thing to watch when landing this alongside #1884: that branch
passes the spelling glob to `matched()` as a second, literal copy of
the same string. The two hunks are far enough apart to merge without
complaint, and whichever lands second leaves the literal in `matched()`
naming the older extension list. It reads only in a failure message,
but it should be brought back into agreement.

Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Assisted-by: Claude-Code:claude-opus-5
The follow-up this branch said it would need. #1884 landed first and
brought `matched(files, ...)`, whose second argument was a second
literal copy of the glob above it -- and the two were already a
version apart, since this branch widened one of them to cover json5
and jsonc and the other still named the older list.

It is read only in the message printed when nothing matched, so
nothing was broken by it. But a string duplicated once has already
shown it will drift, so it is named and referenced twice rather than
written twice.

Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Assisted-by: Claude-Code:claude-opus-5
@DerekNonGeneric
DerekNonGeneric force-pushed the infra/check-what-was-skipped branch from 0048ea8 to b64d03f Compare September 7, 2026 04:05
@DerekNonGeneric DerekNonGeneric added the 🚀 Status: Commit Queue Land this pull request when its checks pass label Sep 7, 2026
@openinf-commit-queue
openinf-commit-queue Bot merged commit 4ec195f into live Sep 7, 2026
18 checks passed
@openinf-commit-queue openinf-commit-queue Bot removed the 🚀 Status: Commit Queue Land this pull request when its checks pass label Sep 7, 2026
@openinf-commit-queue
openinf-commit-queue Bot deleted the infra/check-what-was-skipped branch September 7, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant