Repository navigation
🏗️🔧：fix the settings that quietly do nothing - #1893
Merged
Merged
Conversation
Ported from OpenINF/.github, which carries the corrected spelling of each of these. .ecrc.json said `SpacesAftertabs`. That spelling was deprecated and then removed by editorconfig-checker, which this project pins at 7.0.0, so the key is read by nothing. It is not a behavior change today: the value it sets, `false`, is also the default, so the checker does the same thing either way. What it is is a line that reads as though it configures something and does not, and that stops being harmless the moment the default moves. package.json said `"private": "true"` -- the string, not the boolean. Every consumer of that field tests it for truthiness, so a non-empty string happens to work, and it will keep working right up until something reads it as the boolean the schema says it is. `homepage` said `open.inf.is`, which is a hostname rather than a URL. .deepsource.toml never enabled the shell analyzer, so post-create.sh and post-start.sh -- the two files here most likely to be wrong in a way that only shows up on somebody else's machine -- were analyzed by nothing. Enabled here, along with the explicit `enabled` flags the upstream file carries, test-coverage off because there is none to report, and the prettier transformer off because this project formats with its own prettier configuration and does not want a second opinion committed on top of it. The `[analyzers.meta]` blocks stay where they were relative to the analyzers they belong to; in TOML each attaches to the array entry above it, so the shell analyzer is added before them rather than between one and its meta. .editorconfig now leaves Markdown's indent size unset, because a `1. ` list item continues at three columns and no whole-file indent size describes that. Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is> Assisted-by: Claude-Code:claude-opus-5
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe PR updates DeepSource, EditorConfig, and package metadata. It enables or disables selected analyzers and transformers, corrects a configuration key, adds Markdown editor settings, converts ChangesRepository configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This updates repository configuration and package metadata; no merge-blocking production or user-impact risk is currently established. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
✅ Deploy Preview for gh-pages-openinf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
DerekNonGeneric
added
the
🚀 Status: Commit Queue
openinf-commit-queue
Bot
removed
the
🚀 Status: Commit Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from
OpenINF/.github, which carries the corrected spelling of each of these..ecrc.jsonsaidSpacesAftertabs. That spelling was deprecated and then removed by editorconfig-checker, which this project pins at 7.0.0, so the key is read by nothing. It is not a behavior change today — the value it sets,false, is also the default, so the checker does the same thing either way. What it is is a line that reads as though it configures something and does not, and that stops being harmless the moment the default moves.package.jsonsaid"private": "true"— the string, not the boolean. Every consumer of that field tests it for truthiness, so a non-empty string happens to work, and will keep working right up until something reads it as the boolean the schema says it is.homepagesaidopen.inf.is, which is a hostname rather than a URL..deepsource.tomlnever enabled the shell analyzer. Sopost-create.shandpost-start.sh— the two files here most likely to be wrong in a way that only shows up on somebody else's machine — were analyzed by nothing. Enabled here, along with the explicitenabledflags the upstream file carries,test-coverageoff because there is none to report, and the prettier transformer off because this project formats with its own prettier configuration and does not want a second opinion committed on top of it.Note on the TOML:
[analyzers.meta]attaches to the array entry above it, so the shell analyzer is added before the existing[[analyzers]]/[analyzers.meta]pairs rather than between one and its meta. The javascript analyzer keeps itsenvironmentmeta and docker keeps itsdockerfile_paths..editorconfignow leaves Markdown's indent size unset, because a1.list item continues at three columns and no whole-file indent size describes that.How it was checked
verify.toml,verify.json,verify.validForEC,verify.md,verify.spellingandverify.yamlall pass; no new failures acrossverify.all.Not ported, deliberately
.gitattributesdiffers too, but upstream dropped Git LFS entirely because it has no binary assets. This repository needs those rules, so its version is not the one to copy. Happy to do a separate pass on the duplicate*.pdfline and the missingjson5/jsoncdiff drivers if you want them.Summary by CodeRabbit