Switcam B200 - #156
Switcam B200#156Puzzak01 wants to merge 6 commits into
Conversation
PR Summary by QodoAdd Switcam B200 SSC337DE device profile
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
Code Review by Qodo
1.
|
| # | ||
| # Set custom upgrade url | ||
| # | ||
| fw_setenv upgrade 'https://github.com/OpenIPC/builder/releases/download/latest/ssc337de_ultimate_switcam-b200-nand.tgz' |
There was a problem hiding this comment.
2. First boot requests a missing update 📘 Rule violation ☼ Reliability
3
customizer.sh stores an upgrade URL ending in ssc337de_ultimate_switcam-b200-nand.tgz instead of the required ssc337de_ultimate_switcam-b200-nor.tgz. When the camera invokes its seeded updater, it requests a filename outside the board artifact convention used by the release flow.
Agent Prompt
## Issue description
The first-boot upgrade URL names a NAND archive rather than the required board-specific NOR release artifact.
## Fix Focus Areas
- devices/ssc337de_ultimate_switcam-b200/general/overlay/usr/share/openipc/customizer.sh[8-8]
## Recommended Fix
Change the URL suffix from `ssc337de_ultimate_switcam-b200-nand.tgz` to `ssc337de_ultimate_switcam-b200-nor.tgz`.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| @@ -0,0 +1,5 @@ | |||
| /lib/modules/4.9.84/kernel/fs/lockd/lockd.ko | |||
There was a problem hiding this comment.
3. Firmware keeps unwanted kernel modules 📘 Rule violation ➹ Performance
4
The new exclusion file is named ssc337de.list instead of the flavor-qualified lookup key ssc337de_ultimate.list, even though the device identity declares the ultimate flavor and the repository selects <soc>_<flavor>.list. Because the device payload is copied without renaming files, builds for this target do not consume its five module deletions, retaining the listed NFS modules and preventing those exclusions from contributing to image sizing.
Agent Prompt
## Issue description
The exclusion filename omits the target's `ultimate` flavor, so it does not match the SoC-and-flavor lookup used for this board and its exclusions are not applied.
## Fix Focus Areas
- devices/ssc337de_ultimate_switcam-b200/general/scripts/excludes/ssc337de.list[1-5]
## Recommended Fix
Rename `devices/ssc337de_ultimate_switcam-b200/general/scripts/excludes/ssc337de.list` to `devices/ssc337de_ultimate_switcam-b200/general/scripts/excludes/ssc337de_ultimate.list`, preserving all current exclusion entries unchanged.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
No description provided.