hi3518ev100: add HiWatch DS-I203 device profile - #159
ArthurKoba wants to merge 2 commits into
Conversation
PR Summary by QodoAdd HiWatch DS-I203 HI3518EV100 device profile
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
Code Review by Qodo
1. Firmware targets the wrong chip model
|
|
|
||
| # OpenIPC | ||
| BR2_OPENIPC_SOC_VENDOR="hisilicon" | ||
| BR2_OPENIPC_SOC_MODEL="hi3516cv100" |
There was a problem hiding this comment.
1. Firmware targets the wrong chip model 📘 Rule violation ≡ Correctness
The new defconfig sets BR2_OPENIPC_SOC_MODEL to hi3516cv100 even though the device directory and documented hardware identify an hi3518ev100. Builds using this value identify the board as the wrong model while the separate BR2_OPENIPC_SOC_FAMILY value already supplies the shared hi3516cv100 family.
Agent Prompt
## Issue description
The HiWatch DS-I203 defconfig declares `hi3516cv100` as its SoC model, although the target hardware is `hi3518ev100`; the shared compatibility family is configured separately.
## Fix Focus Areas
- devices/hi3518ev100_lite_hiwatch-ds-i203/br-ext-chip-hisilicon/configs/hi3518ev100_lite_hiwatch-ds-i203_defconfig[34-35]
## Recommended Fix
Change `BR2_OPENIPC_SOC_MODEL` to `hi3518ev100`. Keep `BR2_OPENIPC_SOC_FAMILY="hi3516cv100"` if that is the shared kernel and driver family required by this chip.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
There was a problem hiding this comment.
Fixed. BR2_OPENIPC_SOC_MODEL is now hi3518ev100, while BR2_OPENIPC_SOC_FAMILY remains hi3516cv100 as required by the shared SDK family. I also aligned the kernel config path with the upstream hi3518ev100_lite_defconfig.
8f15291 to
0e46480
Compare
0e46480 to
dff6a96
Compare
Summary
Adds an OpenIPC device profile for the HiWatch DS-I203 camera.
Tested hardware:
The 256 MiB physical memory is configured as 128 MiB Linux + 128 MiB MMZ.
This hardware requires the DDR3/256M U-Boot variant added in OpenIPC/u-boot-hi3516cv100#6.
Device configuration
The profile provides the board-specific configuration required by the DS-I203:
osmem=128M/etc/sensors/imx122_spi_dc_1080p.iniThe first-boot customizer writes the required U-Boot environment and performs a delayed reboot so the memory layout and Ethernet configuration take effect on the next boot.
The IR illumination hardware also supports PWM brightness control and PWM0 was verified working on the camera. The current
hi3516cv100Majestic HAL does not provide PWM backlight control, so the profile uses GPIO ON/OFF control for now.Native PWM support is tracked in OpenIPC/majestic#321.
Hardware validation
Tested end-to-end on a physical HiWatch DS-I203, starting from the original Hikvision firmware and completing the full migration to OpenIPC.
After the first-boot customizer and automatic reboot:
mem=128MFinal firmware build size:
The full device build and repository checks pass.