Repository navigation
refactor: bound local caches and coordinate invalidation - #519
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace four handwritten server caches with bounded
lru-cachestores. Reverse-city and reverse-country results are limited to 4,096 entries, GBFS coverage to 10,000, and autocomplete to 1,000. Keep fixed expiry, successful negative lookups, GBFS request sharing, and autocomplete stale-while-revalidate behavior.Redis remains responsible for shared results, leases and quotas. Host invalidation now clears affected local copies across workers and fences old or overlapping shared fills; local caching pauses if the notification connection is unavailable. Geocoding keys include provider configuration and resolved backend bindings, and runtime shutdown releases local subscriptions.
Pub/Sub notifications propagate asynchronously; this does not provide a linearizable cross-worker read barrier. Entry limits are budgets, not byte-size guarantees. Scoped Redis deletion retains its existing glob semantics; affected integration-local copies are flushed conservatively.
Verification
pnpm verify:fullpassed: lint, all 30 workspace type tasks, policy/generation/OpenAPI checks, and 1,760 test files / 20,333 tests passed (191 tests skipped, including the five separately exercised Valkey tests).Release and upgrade impact
No package release: the changed packages are private server/framework workspaces; published extension contracts and SDK outputs are unchanged.
Product impact: none
Caches repopulate normally under the new identities. No migration or operator action is required. No compatibility fallback is retained.