Repository navigation
feat: add wait helpers to run all cells - #9545
Merged
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
pjwerneck
added this pull request to stack #9546
October 1, 2026 18:48
pjwerneck
changed the title
pjwerneck
changed the title
pjwerneck
force-pushed
the
pjwerneck/wait-for-helpers
branch
from
October 5, 2026 13:06
56f7365 to
b4a8b7b
Compare
wait_until_peered, wait_until_has_dataset and wait_until_has_job wait until the other party is done, so two notebooks run end to end without re-run cells. wait_until_has_job takes a status and a where= condition, and fails at once on a final status that was not asked for. The enclave client adds wait_until_attested. The demo notebooks use the helpers.
… remove redundant import in tests
pjwerneck
force-pushed
the
pjwerneck/wait-for-helpers
branch
from
October 7, 2026 01:51
b4a8b7b to
30bcee7
Compare
rasswanth-s
approved these changes
Oct 7, 2026
pjwerneck
removed this pull request from stack #9546
October 7, 2026 14:24
pjwerneck
marked this pull request as draft
October 7, 2026 14:28
pjwerneck
marked this pull request as ready for review
October 7, 2026 14:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds wait helpers to the RDS and enclave clients, so a notebook cell waits until the other party is
done. Two demo notebooks can then run all their cells without anyone re-running cells by hand.
Depends on #9537.
Changes
wait_until_peered,wait_until_has_datasetandwait_until_has_jobonSyftRDSClientandSyftEnclaveClient.wait_until_attestedonSyftEnclaveClient.wait_until_has_jobtakesstatus=andwhere=, and fails at once on a final status that wasnot asked for. A job name used by more than one submitter or datasite raises
ValueError; repeatedruns of the same job resolve to the newest.
300 s.
Testing
threads, linked only by the waits.
ran all cells at the same time and finished in 375 s, meeting only through the waits.
Asana task