Repository navigation
Fix saving of empty "marker-message" values to printers.conf. - #1757
Merged
michaelrsweet merged 1 commit intoOct 12, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was written by an AI assistant (Claude), working with and reviewed by @toppk.
Issue: When a printer reports an empty
marker-message,cupsdSaveAllPrinters()writesAttribute marker-messageto printers.conf.cupsFileGetConf()strips the trailing space, so on the next startcupsdLoadAllPrinters()logsSyntax error on line N of printers.conf.The next job writes the line again, so the error comes back after every restart. We hit this with a driverless IPP printer (Dell E525w) on 2.4.19.Fix: Save an empty message as
Attribute marker-message "". The existing loader already parses this as an empty string, so the load code doesn't change, and older cupsd versions read the file without error. There are other ways to handle this, such as skipping the line or relaxing the loader. This is the smallest change.Tested by saving and reloading printers.conf with master and a patched 2.4.19.
🤖 Generated with Claude Code