Skip to content

Fix conditional definition of the Windows DNS-SD service structure - #178

Closed
mbricaud49 wants to merge 1 commit into
OpenPrinting:masterfrom
mbricaud49:fix/mdnsresponder-conditional-compilation
Closed

mbricaud49 wants to merge 1 commit into
OpenPrinting:masterfrom
mbricaud49:fix/mdnsresponder-conditional-compilation

Conversation

@mbricaud49

Copy link
Copy Markdown

Fixes the conditional declaration of struct _win32_srv_s in cups/dnssd.c.
The structure is specific to the native Windows DNS-SD implementation and is now declared only when HAVE_MDNSRESPONDER is not enabled. This prevents Windows DNS API types such as DNS_SERVICE_REGISTER_REQUEST from being referenced when using the mDNSResponder backend.

@michaelrsweet michaelrsweet self-assigned this Oct 14, 2026
@michaelrsweet michaelrsweet added the platform issue Issue is specific to an OS or desktop label Oct 14, 2026
@michaelrsweet michaelrsweet added this to the Stable milestone Oct 14, 2026
@michaelrsweet

Copy link
Copy Markdown
Member

I opted to combine the preprocessor condition test:

[master 0d6a0db] Fix mDNSResponder support on Windows (Issue #178)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform issue Issue is specific to an OS or desktop

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants