Use defaultdict on suppress_warning to simplify empty lists - #3549
Merged
Merged
Conversation
This has two main benefits: - makes the file a lot simpler since we don't need to define the empty lists for languages without suppressions - new languages won't automatically fail the CI until someone merges an empty list into the master branch
tupaschoal
marked this pull request as ready for review
September 26, 2026 10:47
Gymnasiast
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has two main benefits:
Will help the follow-up of #3432
Without this patch, adding a new language and running
translation_check.pywould yield: