Repository navigation
Conversation
c2fa258 to
5fd49a3
Compare
|
Apparently it builds. Because release candidates use - in filenames and ~ in URLS (and I guess it'll happen in the future) I added a parameter and steps that override the download folder in the URL |
5fd49a3 to
51113f6
Compare
|
Testing it out locally and I'm running into issues. It looks like |
|
So, we push to main, it triggers the |
462b8e9 to
d3c021f
Compare
That should now be taken care of by
Should be fixed, floating tags are updated conditionally now |
d3c021f to
146140c
Compare
|
@MirandaStreeter should work now |
|
It consistently builds now. But it looks like you're updating the github workflow files directly. These are managed files. For example, at the top of In short, the I'm pretty sure the next time any kind of workflow runs on the modulesync_config repository a modulesync is triggered across the org, and some of your Apologies if this is adding a lot of complexity. I always have to re-review how this rube goldberg machine works myself. |
Ok, tried to moved changes there with a separate commit to keep track of changes (should be squashed at merge time). How am I supposed to correctly "merge" them now? The CI is back to its previous state Also removed the workaround for Release Candidate URLs |
5d140b8 to
bf46139
Compare
|
You'll want to follow the instructions outlined here:
For the finer details I think the #voxpupuli channel in Slack/IRC would be a good spot to ask, or the mailing list if posterity is important. |
| install puppet-server-release.jar "/opt/puppetlabs/server/apps/puppetserver" -m 0644 | ||
| install ext/ezbake-functions.sh "/opt/puppetlabs/server/apps/puppetserver/ezbake-functions.sh" -m 0755 | ||
| # Not present in OpenVox 9 | ||
| [ -f ext/ezbake-functions.sh ] && install ext/ezbake-functions.sh "/opt/puppetlabs/server/apps/puppetserver/ezbake-functions.sh" -m 0755 |
There was a problem hiding this comment.
that sounds like an ezbake bug that we should fix
There was a problem hiding this comment.
does the server start without it? i can remember having some problems with it if missing 🤔
There was a problem hiding this comment.
I built the image locally (both ubuntu and alpine), and ovxserver 9 starts without it (or at least the healthcheck).
Only tweak might be the comment, should be "Not present in ezbake 4, necessary for OpenVox 8".
30df8fb to
d95d5ec
Compare
|
@MirandaStreeter I was able to make it work |
|
Perfect, moving the parameters to But before releasing I'd like one more set of eyes, considering this is a major bump. @rwaffen? |
rwaffen
left a comment
There was a problem hiding this comment.
LGTM, but not sure about the missing ezbake-functions.sh
Me too, I just took the content of the .tar.gz artifact as good |
|
I quote from IRC/Slack @Sharpie Relevant PR: https://github.com/OpenVoxProject/ezbake/pull/25/changes |
Signed-off-by: Francesco Di Nucci <d1nuc0m@protonmail.com>
d95d5ec to
5f4f259
Compare
Short description
Start building containers for OpenVox 9. First attempt at containers, there will be changes to do.
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent