Repository navigation
Enforce a min destination gas limit - #3012
Merged
Merged
Conversation
shahthepro
requested review from
clement-ux,
naddison36 and
sparrowDom
as code owners
September 29, 2026 08:40
shahthepro
added a commit
that referenced
this pull request
Oct 8, 2026
* Add OUSD V3 contracts * Fixes * Simplify code * Remove root pnpm files * Refactor superbridge * checkpoint * Add testnet files and bug fixes * Fix tests * Add flows file * Fix pnpm lock file * Fix slither * Fix Base fork test * Commit readme files * bug fixes * Fix hh config * Fix hh config * Move testnet harness to shah/ousd-v3-testnet * Fix unit test * Fix AbstractAdapter * Update comment * Code simplification * bug fixes * Few more code cleanup * Simplify code * Update flows * Bug fixes * Clamp to zero instead of revert * Fix comment * Fix docs * Fix comments * Added OUSD v3 contract diagrams * Updated flow diagrams * More sequence diagram rendering fixes and improvements * More Deposit sequence diagram changes * More sequence diagram changes * More deposit sequence diagram changes * More sequence diagram changes * More deposit sequence changes * Added store prefix when writing to a storage variable Moved the adapter participants close to the Bridge * Clearer message structures * More sequence changes * More sequence diagram changes * More flow changes * More deposit flow changes * Withdraw flow updates * More withdraw flow sequence diagram changes * Check balance diagram changes * Bridge out and in sequence diagrams * Settlement flow diagram changes * Update check balance flow diagram * Address CR comments * Rename var * Bug fixes * Update docs and comments * Add missing check * Simplify CrossChainStrategyV3 * Fix linting issues * Fix lint issues * Fix docs and stuff * Make balance check push-only * std-001: merge CLAUDE.md into AGENTS.md, symlink CLAUDE.md Both files existed as real files. CLAUDE.md held all 298 lines of real guidance; AGENTS.md held 40 lines written on another machine. Merge decisions: - Workflow guidance (prettier, smallest-verification, do-not-reformat): present in both, word for word. Kept CLAUDE.md's copy. - 'Run repo commands from /Users/nicholasaddison/.../contracts' loses to 'Run repo commands from contracts/'. The absolute path is another engineer's home directory and is wrong everywhere but that machine. - Dropped the hand-maintained 'Skills' registry. It listed four skills by absolute path under /Users/clement/.codex/skills and /Users/clement/Documents, none of which resolve here, plus 25 lines instructing the agent how to discover and load skills. Skill discovery is the harness's job and differs per harness; a checked-in registry of one engineer's local paths is exactly the rot-prone state STD-001 forbids. If those skills are worth sharing they belong in the repo under .agents/skills/ (STD-003), not as pointers into a home directory. Verified with automation/scripts/check-agents-md.sh. AGENTS.md is 298 lines, over the 200-line content rule. Not addressed here: splitting it (storage-layout checks and the Foundry/Talos mandatory check are the candidates for .claude/rules/) changes what every agent in this repo reads and should be its own reviewed change. * Fix gas bug * Migrate deploy scripts to foundry * Seed the storage baseline for the BridgedWOETHStrategy upgrade The deploy-time gate keys on the contract name, so BridgedWOETHMigrationStrategy had no descriptor on Base and passed as a brand-new contract — the one upgrade in this stack that touches a live proxy ran without a layout comparison. Seed deployments/base/BridgedWOETHMigrationStrategy.json with the live BridgedWOETHStrategy storage layout so check-storage-upgrade.js compares the new implementation against what the proxy runs today. Verified both ways: the gate passes on the real layout (totalBridged/maxPerBridge appended after V1's slot-157 tail) and exits 1 with a layoutchange finding if a V1 slot moves. The post-deploy descriptor refresh replaces the seed wholesale. * Renumber mainnet deploy scripts 005/006 to 006/007 Master gained 005_DeployOETHVaultLens.s.sol (#2953) after this branch diverged, so the OETHb V3 mainnet scripts would collide with it on merge. Bump file names, contract names and constructor deployment IDs, and update the cross-references in base/002, base/003, the RemoteWOTokenStrategy fork test comment, DESIGN.md and README.md. Neither script has been broadcast, so no deployment state is affected. * Fix smoke tests * retryDeposit deposits only idle funds (#3010) * Fix Interface usage (#3011) * Enforce a min destination gas limit (#3012) * Fix withdrawal tests * Remove symlink * Re-add skill files --------- Co-authored-by: Nicholas Addison <nick@addisonbrown.com.au> Co-authored-by: Domen Grabec <grabec@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Change