Conversation
This was referenced Sep 20, 2026
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relation callbacks lost custom builders in two places: custom query receivers were not recognized as model builders, and related models always became the base Builder. Use the receiver’s existing resolved generic context and share the model builder selector with static forwarding, including inherited configuration and non-generic custom builders.
A bare parent-class parameter hint can now retain an inferred generic subclass. Explicit incompatible hints remain authoritative. Adds type, completion, diagnostic, and Laravel runtime regressions, and removes completed L56 from the backlog.
Stack: depends on #448, above upstream audit #447. This stacked PR targets upstream
main, so its diff includes the unmerged dependencies. The L56 change is commite419ac0f; merge the dependencies first.Validation: full cargo test, both required clippy runs, cargo fmt --check, PHP syntax/runtime assertions, and Laravel analysis with exactly its three intentional diagnostics.