Repository navigation
feat: redesign goals with durable reading tracking - #40
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5c5e8b237
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace in-memory goals and example sessions with a profile-scoped reading ledger. Reader checkpoints persist offline, goal progress derives from eligible activity, and Dashboard/Statistics use the same source. Calendar periods, recurrence, pauses, corrections, explicit completion/undo, overlap deduplication, and book/page coverage preserve inspectable history.
Overview now groups goals by progress: In progress, Not started, Completed, and Paused. A compact filter hides completed goals. Overview and Activity are swipeable, with the same tab height and collection-page spacing as the rest of the app. Desktop actions sit beside the tabs; phones use compact Log reading and a New goal FAB. Activity groups book/day entries and provides a full-width heatmap, filters, and expandable goal history.
Creation defaults to Daily, with an editable target, recurrence, library/shelf/multiple-book scope, and searchable book selection. A books-finished target cannot exceed the selected book count. Goal and activity detail sheets use compact summaries, book covers/authors, fixed footers, and readable multiline inputs. Activity expansion state has distinct saved-state keys from scroll offsets, fixing the crash when revisiting archived history. Time details show eligible duration after creation cutoffs and overlapping logs.
Validation
Screenshots
Desktop Overview
Activity
Goal creation
Mobile Overview
Compatibility and delivery
Reader revision remains pinned to
bc617deeaf2ae684f20c1000ed7cd52f9a61d0a7. Server tracking capability version 2 addsbook_ids; single-book/library goals retain version-1 payloads. Unsupported multi-book uploads remain staged so ordinary library synchronization continues. Existing additive migration/publication/PowerSync setup must be deployed before the integrated client release.Versions remain unchanged. Target
development; coordinate server #12, reader #5, and workspace #13. Scheduled reminders and composite challenges remain follow-up work.